feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Replace virtual isModified method with a getter/setter/notifier

Browse Source 
We have lacked the setter and dedicated notifier before.

Change-Id: I58845a48259d260c5cc90ae94b173c79cddcfef9
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
This commit is contained in:
Jarek Kobus
2016-10-07 15:58:40 +02:00
committed by Jarek Kobus
parent caf721430b
commit 59c90e00c1
28 changed files with 113 additions and 136 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/texteditor/textdocument.cpp
View File

@@ -236,13 +236,16 @@ void TextDocumentPrivate::updateRevisions()
TextDocument::TextDocument(Id id)
: d(new TextDocumentPrivate)
{
QObject::connect(&d->m_document, &QTextDocument::modificationChanged, [this](bool modified) {
connect(&d->m_document, &QTextDocument::modificationChanged, [this](bool modified) {
// we only want to update the block revisions when going back to the saved version,
// e.g. with undo
if (!modified)
d->updateRevisions();
emit changed();
setModified(modified);
});
connect(this, &IDocument::modificationChanged, &d->m_document, &QTextDocument::setModified);
setModified(d->m_document.isModified());
connect(&d->m_document, &QTextDocument::contentsChanged,
this, &Core::IDocument::contentsChanged);
@@ -595,11 +598,6 @@ bool TextDocument::isFileReadOnly() const
return d->m_fileIsReadOnly;
}
bool TextDocument::isModified() const
{
return d->m_document.isModified();
}
void TextDocument::checkPermissions()
{
bool previousReadOnly = d->m_fileIsReadOnly;