feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlProfiler: Fix flame graph view test

Browse Source 
Clicking in an empty area closes the details window now.

Change-Id: I7108b6339021707097bd2a852230fa60473d18e5
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
This commit is contained in:
Ulf Hermann
2018-04-20 18:01:15 +02:00
parent 1770c2ffe2
commit 59e641f8e6
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/qmlprofiler/tests/flamegraphview_test.cpp
View File

@@ -58,8 +58,9 @@ void FlameGraphViewTest::testSelection()
QCOMPARE(file, QLatin1String("somefile.js")); QCOMPARE(file, QLatin1String("somefile.js"));
}); });
auto con2 = connect(&view, &QmlProfilerEventsView::typeSelected, [](int selected) { int expectedType = 0;
QCOMPARE(selected, 0); auto con2 = connect(&view, &QmlProfilerEventsView::typeSelected, [&](int selected) {
QCOMPARE(selected, expectedType);
}); });
QSignalSpy spy(&view, SIGNAL(typeSelected(int))); QSignalSpy spy(&view, SIGNAL(typeSelected(int)));
@@ -71,12 +72,13 @@ void FlameGraphViewTest::testSelection()
view.selectByTypeId(1); view.selectByTypeId(1);
QCOMPARE(spy.count(), 1); QCOMPARE(spy.count(), 1);
// Click in empty area shouldn't change anything, either // Click in empty area deselects
expectedType = -1;
QTest::mouseClick(view.childAt(250, 250), Qt::LeftButton, Qt::NoModifier, QPoint(495, 50)); QTest::mouseClick(view.childAt(250, 250), Qt::LeftButton, Qt::NoModifier, QPoint(495, 50));
QCOMPARE(spy.count(), 1); QCOMPARE(spy.count(), 2);
view.onVisibleFeaturesChanged(1 << ProfileBinding); view.onVisibleFeaturesChanged(1 << ProfileBinding);
QCOMPARE(spy.count(), 1); // External event: still doesn't change anything QCOMPARE(spy.count(), 2); // External event: still doesn't change anything
disconnect(con1); disconnect(con1);
disconnect(con2); disconnect(con2);