diff --git a/src/libs/extensionsystem/plugindetailsview.cpp b/src/libs/extensionsystem/plugindetailsview.cpp index 540cbf57cc3..07531e552a9 100644 --- a/src/libs/extensionsystem/plugindetailsview.cpp +++ b/src/libs/extensionsystem/plugindetailsview.cpp @@ -70,16 +70,6 @@ PluginDetailsView::~PluginDetailsView() delete m_ui; } -// TODO: make API in PluginSpec -static QString getSpecRevision(PluginSpec *spec) -{ - const QJsonObject metaData = spec->metaData(); - const QJsonValue revision = metaData.value("Revision"); - if (revision.isString()) - return revision.toString(); - return QString(); -} - /*! Reads the given \a spec and displays its values in this PluginDetailsView. @@ -87,7 +77,7 @@ static QString getSpecRevision(PluginSpec *spec) void PluginDetailsView::update(PluginSpec *spec) { m_ui->name->setText(spec->name()); - const QString revision = getSpecRevision(spec); + const QString revision = spec->revision(); const QString versionString = spec->version() + (revision.isEmpty() ? QString() : " (" + revision + ")"); m_ui->version->setText(versionString); diff --git a/src/libs/extensionsystem/pluginspec.cpp b/src/libs/extensionsystem/pluginspec.cpp index 16308f751f9..8e5b3e02ecb 100644 --- a/src/libs/extensionsystem/pluginspec.cpp +++ b/src/libs/extensionsystem/pluginspec.cpp @@ -288,6 +288,14 @@ QString PluginSpec::category() const return d->category; } +QString PluginSpec::revision() const +{ + const QJsonValue revision = metaData().value("Revision"); + if (revision.isString()) + return revision.toString(); + return QString(); +} + /*! Returns a QRegularExpression matching the platforms this plugin works on. An empty pattern implies all platforms. diff --git a/src/libs/extensionsystem/pluginspec.h b/src/libs/extensionsystem/pluginspec.h index 1614773b27a..2180d916dd5 100644 --- a/src/libs/extensionsystem/pluginspec.h +++ b/src/libs/extensionsystem/pluginspec.h @@ -92,6 +92,7 @@ public: QString description() const; QString url() const; QString category() const; + QString revision() const; QRegularExpression platformSpecification() const; bool isAvailableForHostPlatform() const; bool isRequired() const;