feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CppTools: Remove ProjectInfo::operator bool()

Browse Source 
This one does not buy us much...

Change-Id: I1d6c4667c038d319d2c16166505a386653a9f066
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@theqtcompany.com>
This commit is contained in:
Nikolai Kosjar
2014-11-06 14:30:47 +01:00
parent 3f0aa88012
commit 5a1ffe6f1c
3 changed files with 3 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/cpptools/cppprojects.cpp
View File

@@ -137,11 +137,6 @@ ProjectInfo::ProjectInfo(QPointer<ProjectExplorer::Project> project)
: m_project(project) : m_project(project)
{} {}
ProjectInfo::operator bool() const
{
return isValid();
}
bool ProjectInfo::isValid() const bool ProjectInfo::isValid() const
{ {
return !m_project.isNull(); return !m_project.isNull();

1
src/plugins/cpptools/cppprojects.h
View File

@@ -140,7 +140,6 @@ public:
ProjectInfo(); ProjectInfo();
ProjectInfo(QPointer<ProjectExplorer::Project> project); ProjectInfo(QPointer<ProjectExplorer::Project> project);
operator bool() const;
bool isValid() const; bool isValid() const;
QPointer<ProjectExplorer::Project> project() const; QPointer<ProjectExplorer::Project> project() const;

6
src/plugins/genericprojectmanager/genericprojectplugin_test.cpp
View File

@@ -107,7 +107,7 @@ void GenericProjectPlugin::test_simple()
const QByteArray mainFile("testdata_simpleproject/main.cpp"); const QByteArray mainFile("testdata_simpleproject/main.cpp");
ProjectInfo pInfo( ProjectInfo pInfo(
setupProject("testdata_simpleproject/simpleproject.creator", mainFile, pHelper)); setupProject("testdata_simpleproject/simpleproject.creator", mainFile, pHelper));
QVERIFY(pInfo); QVERIFY(pInfo.isValid());
QCOMPARE(pInfo.projectParts().size(), 1); QCOMPARE(pInfo.projectParts().size(), 1);
ProjectPart::Ptr pPart = pInfo.projectParts().first(); ProjectPart::Ptr pPart = pInfo.projectParts().first();
@@ -138,7 +138,7 @@ void GenericProjectPlugin::test_mixed1()
setupProject("testdata_mixedproject1/mixedproject1.creator", setupProject("testdata_mixedproject1/mixedproject1.creator",
"testdata_mixedproject1/main.cpp", "testdata_mixedproject1/main.cpp",
pHelper)); pHelper));
QVERIFY(pInfo); QVERIFY(pInfo.isValid());
QCOMPARE(pInfo.projectParts().size(), 3); QCOMPARE(pInfo.projectParts().size(), 3);
QList<ProjectPart::Ptr> parts = pInfo.projectParts(); QList<ProjectPart::Ptr> parts = pInfo.projectParts();
@@ -183,7 +183,7 @@ void GenericProjectPlugin::test_mixed2()
setupProject("testdata_mixedproject2/mixedproject2.creator", setupProject("testdata_mixedproject2/mixedproject2.creator",
"testdata_mixedproject2/main.cpp", "testdata_mixedproject2/main.cpp",
pHelper)); pHelper));
QVERIFY(pInfo); QVERIFY(pInfo.isValid());
QCOMPARE(pInfo.projectParts().size(), 2); QCOMPARE(pInfo.projectParts().size(), 2);
QList<ProjectPart::Ptr> parts = pInfo.projectParts(); QList<ProjectPart::Ptr> parts = pInfo.projectParts();