From 5ad0cbc070fc1536a358b63d17261dfba03c8230 Mon Sep 17 00:00:00 2001 From: Tim Jenssen Date: Fri, 23 Dec 2016 16:13:14 +0100 Subject: [PATCH] QmlDesigner: remove unnecessary save method Change-Id: Ia2a195c84ce83bc3a83155cc19b0585475a5547a Reviewed-by: Thomas Hartmann --- .../designercore/include/plaintexteditmodifier.h | 2 -- .../designercore/model/plaintexteditmodifier.cpp | 5 ----- tests/auto/qml/qmldesigner/coretests/tst_testcore.cpp | 8 +------- 3 files changed, 1 insertion(+), 14 deletions(-) diff --git a/src/plugins/qmldesigner/designercore/include/plaintexteditmodifier.h b/src/plugins/qmldesigner/designercore/include/plaintexteditmodifier.h index 210f2c30408..c6cc51911e7 100644 --- a/src/plugins/qmldesigner/designercore/include/plaintexteditmodifier.h +++ b/src/plugins/qmldesigner/designercore/include/plaintexteditmodifier.h @@ -49,8 +49,6 @@ public: PlainTextEditModifier(QPlainTextEdit *textEdit); ~PlainTextEditModifier(); - virtual void save(QIODevice *device); - QTextDocument *textDocument() const override; QString text() const override; QTextCursor textCursor() const override; diff --git a/src/plugins/qmldesigner/designercore/model/plaintexteditmodifier.cpp b/src/plugins/qmldesigner/designercore/model/plaintexteditmodifier.cpp index 30893b20d7f..700afd7a429 100644 --- a/src/plugins/qmldesigner/designercore/model/plaintexteditmodifier.cpp +++ b/src/plugins/qmldesigner/designercore/model/plaintexteditmodifier.cpp @@ -52,11 +52,6 @@ PlainTextEditModifier::~PlainTextEditModifier() { } -void PlainTextEditModifier::save(QIODevice *device) -{ - device->write(m_textEdit->toPlainText().toUtf8()); -} - void PlainTextEditModifier::replace(int offset, int length, const QString &replacement) { #if 0 diff --git a/tests/auto/qml/qmldesigner/coretests/tst_testcore.cpp b/tests/auto/qml/qmldesigner/coretests/tst_testcore.cpp index b14912b4d6f..49171320ad3 100644 --- a/tests/auto/qml/qmldesigner/coretests/tst_testcore.cpp +++ b/tests/auto/qml/qmldesigner/coretests/tst_testcore.cpp @@ -380,11 +380,6 @@ void tst_TestCore::saveEmptyCoreModel() testRewriterView1->setTextModifier(&modifier1); model1->attachView(testRewriterView1.data()); - - QBuffer buffer; - buffer.open(QIODevice::ReadWrite | QIODevice::Text); - modifier1.save(&buffer); - QPlainTextEdit textEdit2; textEdit2.setPlainText("import QtQuick 1.1; Item{}"); NotIndentingTextEditModifier modifier2(&textEdit2); @@ -396,7 +391,6 @@ void tst_TestCore::saveEmptyCoreModel() model2->attachView(testRewriterView2.data()); QVERIFY(compareTree(testRewriterView1->rootModelNode(), testRewriterView2->rootModelNode())); - } void tst_TestCore::loadAttributesInCoreModel() @@ -453,7 +447,7 @@ void tst_TestCore::saveAttributesInCoreModel() QBuffer buffer; buffer.open(QIODevice::ReadWrite | QIODevice::Text); - modifier1.save(&buffer); + buffer.write(modifier1.textDocument()->toPlainText().toUtf8()); QPlainTextEdit textEdit2; textEdit2.setPlainText(QString::fromUtf8(buffer.data()));