From 5ad657ff2c4aed73e62984433d9bf25c853aecdf Mon Sep 17 00:00:00 2001 From: Thomas Hartmann Date: Wed, 5 Jun 2024 17:14:47 +0200 Subject: [PATCH] QmlDesigner: Adjust regular expression MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is a heuristic to detect expressions and we should require at least a single "." to distinguish true/false and simple string literals. The implcit binding detection is not ideal, because there are still false positives. Task-number: QDS-12888 Change-Id: I23b5dd44ff3150f6d5a4ec94bd7a19b5e2117f5b Reviewed-by: Henning Gründl (cherry picked from commit 8f58dc6de92bd0ea86ddfd26f9e452126a5a57d4) Reviewed-by: Thomas Hartmann --- .../components/connectioneditor/connectioneditorutils.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/qmldesigner/components/connectioneditor/connectioneditorutils.cpp b/src/plugins/qmldesigner/components/connectioneditor/connectioneditorutils.cpp index 3cbfb8c0383..214d828603f 100644 --- a/src/plugins/qmldesigner/components/connectioneditor/connectioneditorutils.cpp +++ b/src/plugins/qmldesigner/components/connectioneditor/connectioneditorutils.cpp @@ -203,7 +203,7 @@ bool isBindingExpression(const QVariant &value) if (value.metaType().id() != QMetaType::QString) return false; - QRegularExpression regexp("^[a-z_]\\w*|^[A-Z]\\w*\\.{1}([a-z_]\\w*\\.?)+"); + QRegularExpression regexp("^[a-zA-Z_]\\w*\\.{1}([a-z_]\\w*\\.?)+"); QRegularExpressionMatch match = regexp.match(value.toString()); return match.hasMatch(); }