feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

DiffEditorController: Simplify API

Browse Source 
Get rid of VcsBaseDiffEditorController::setWorkingDirectory()
and rename DiffEditorController::setBaseDirectory() into
setWorkingDirectory(). Don't pass workingDirectory
inside setDiffFiles().

Change-Id: I6a3a02d5e3ddc23977ed2908cd8d7b8ed51a9ee0
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Jarek Kobus
2022-12-14 22:16:49 +01:00
parent ce161d0b16
commit 5aedb4ba56
8 changed files with 33 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/plugins/diffeditor/diffeditorcontroller.cpp
View File

@@ -32,14 +32,14 @@ bool DiffEditorController::isReloading() const
return m_isReloading;
}
FilePath DiffEditorController::baseDirectory() const
FilePath DiffEditorController::workingDirectory() const
{
return m_document->baseDirectory();
return m_document->workingDirectory();
}
void DiffEditorController::setBaseDirectory(const FilePath &directory)
void DiffEditorController::setWorkingDirectory(const FilePath &directory)
{
m_document->setBaseDirectory(directory);
m_document->setWorkingDirectory(directory);
}
int DiffEditorController::contextLineCount() const
@@ -76,10 +76,9 @@ DiffEditorController *DiffEditorController::controller(Core::IDocument *document
return doc ? doc->controller() : nullptr;
}
void DiffEditorController::setDiffFiles(const QList<FileData> &diffFileList,
const FilePath &workingDirectory)
void DiffEditorController::setDiffFiles(const QList<FileData> &diffFileList)
{
m_document->setDiffFiles(diffFileList, workingDirectory);
m_document->setDiffFiles(diffFileList);
}
void DiffEditorController::setDescription(const QString &description)