feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

DiffEditorController: Simplify API

Browse Source 
Get rid of VcsBaseDiffEditorController::setWorkingDirectory()
and rename DiffEditorController::setBaseDirectory() into
setWorkingDirectory(). Don't pass workingDirectory
inside setDiffFiles().

Change-Id: I6a3a02d5e3ddc23977ed2908cd8d7b8ed51a9ee0
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Jarek Kobus
2022-12-14 22:16:49 +01:00
parent ce161d0b16
commit 5aedb4ba56
8 changed files with 33 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/diffeditor/diffeditorcontroller.h
View File

@@ -30,8 +30,8 @@ public:
void requestReload();
bool isReloading() const;
Utils::FilePath baseDirectory() const;
void setBaseDirectory(const Utils::FilePath &directory);
Utils::FilePath workingDirectory() const;
void setWorkingDirectory(const Utils::FilePath &directory);
int contextLineCount() const;
bool ignoreWhitespace() const;
@@ -67,8 +67,7 @@ protected:
void reloadFinished(bool success);
void setStartupFile(const QString &startupFile);
void setDiffFiles(const QList<FileData> &diffFileList,
const Utils::FilePath &baseDirectory = {});
void setDiffFiles(const QList<FileData> &diffFileList);
void setDescription(const QString &description);
QString description() const;
void forceContextLineCount(int lines);