feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

DiffEditorController: Simplify API

Browse Source 
Get rid of VcsBaseDiffEditorController::setWorkingDirectory()
and rename DiffEditorController::setBaseDirectory() into
setWorkingDirectory(). Don't pass workingDirectory
inside setDiffFiles().

Change-Id: I6a3a02d5e3ddc23977ed2908cd8d7b8ed51a9ee0
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Jarek Kobus
2022-12-14 22:16:49 +01:00
parent ce161d0b16
commit 5aedb4ba56
8 changed files with 33 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/plugins/vcsbase/vcsbasediffeditorcontroller.cpp
View File

@@ -46,7 +46,6 @@ public:
void commandFinished(bool success);
VcsBaseDiffEditorController *q;
FilePath m_directory;
Environment m_processEnvironment;
FilePath m_vcsBinary;
int m_vscTimeoutS;
@@ -75,7 +74,7 @@ void VcsBaseDiffEditorControllerPrivate::processingFinished()
m_processWatcher->deleteLater();
m_processWatcher = nullptr;
q->setDiffFiles(fileDataList, q->workingDirectory());
q->setDiffFiles(fileDataList);
q->reloadFinished(success);
}
@@ -180,17 +179,6 @@ void VcsBaseDiffEditorController::processCommandOutput(const QString &output)
d->processDiff(output);
}
FilePath VcsBaseDiffEditorController::workingDirectory() const
{
return d->m_directory;
}
void VcsBase::VcsBaseDiffEditorController::setWorkingDirectory(const FilePath &workingDir)
{
d->m_directory = workingDir;
setBaseDirectory(workingDir);
}
void VcsBaseDiffEditorController::setVcsTimeoutS(int value)
{
d->m_vscTimeoutS = value;