From 5b1035c20f9ae2a3b4b546a1ced6a4bb27c044de Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Thu, 31 Mar 2022 09:18:23 +0200 Subject: [PATCH] Forward declare QtcProcess instead of #include The QtcProcess is already forward declared in idevice.h. In case of std::unique_ptr being a member of a public class in a header file it's enough to deinline constructor and destructor of a class containing the member, and forward declare MyClass. Amends f91a9cb8916183377dee6c708b2f4ca168710f88 Change-Id: Iacf272b62fed8827c0451c5d4c5c3429bb7106ef Reviewed-by: Christian Stenger --- src/plugins/android/androidsignaloperation.cpp | 2 ++ src/plugins/android/androidsignaloperation.h | 3 +-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/plugins/android/androidsignaloperation.cpp b/src/plugins/android/androidsignaloperation.cpp index 9983e300b76..15e3d2f7b9e 100644 --- a/src/plugins/android/androidsignaloperation.cpp +++ b/src/plugins/android/androidsignaloperation.cpp @@ -42,6 +42,8 @@ AndroidSignalOperation::AndroidSignalOperation() connect(m_timeout, &QTimer::timeout, this, &AndroidSignalOperation::handleTimeout); } +AndroidSignalOperation::~AndroidSignalOperation() = default; + void AndroidSignalOperation::adbFindRunAsFinished() { QTC_ASSERT(m_state == RunAs, return); diff --git a/src/plugins/android/androidsignaloperation.h b/src/plugins/android/androidsignaloperation.h index abaee2af223..8aedd15a859 100644 --- a/src/plugins/android/androidsignaloperation.h +++ b/src/plugins/android/androidsignaloperation.h @@ -26,7 +26,6 @@ #pragma once #include -#include #include #include @@ -38,7 +37,7 @@ class AndroidSignalOperation : public ProjectExplorer::DeviceProcessSignalOperat { Q_OBJECT public: - ~AndroidSignalOperation() override = default; + ~AndroidSignalOperation() override; void killProcess(qint64 pid) override; void killProcess(const QString &filePath) override; void interruptProcess(qint64 pid) override;