feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QtQuickCompilerAspect: Use better connection guard object

Browse Source 
The aspect may outlive its widgets.

Change-Id: I93d742e15277f64d1919739a2244736fb294e5b0
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
hjk
2021-03-23 09:58:55 +01:00
parent f28b0fe6a1
commit 5b13fb2168
1 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/plugins/qtsupport/qtbuildaspects.cpp
View File

@@ -70,8 +70,8 @@ void QmlDebuggingAspect::addToLayout(LayoutBuilder &builder)
if (warningLabel->parentWidget()) if (warningLabel->parentWidget())
warningLabel->setVisible(warningLabelsVisible); warningLabel->setVisible(warningLabelsVisible);
}; };
connect(KitManager::instance(), &KitManager::kitsChanged, this, changeHandler); connect(KitManager::instance(), &KitManager::kitsChanged, warningLabel, changeHandler);
connect(this, &QmlDebuggingAspect::changed, this, changeHandler); connect(this, &QmlDebuggingAspect::changed, warningLabel, changeHandler);
changeHandler(); changeHandler();
} }
@@ -105,13 +105,11 @@ void QtQuickCompilerAspect::addToLayout(LayoutBuilder &builder)
if (warningLabel->parentWidget()) if (warningLabel->parentWidget())
warningLabel->setVisible(warningLabelsVisible); warningLabel->setVisible(warningLabelsVisible);
}; };
connect(KitManager::instance(), &KitManager::kitsChanged, this, changeHandler); connect(KitManager::instance(), &KitManager::kitsChanged, warningLabel, changeHandler);
connect(this, &QmlDebuggingAspect::changed, this, changeHandler); connect(this, &QmlDebuggingAspect::changed, warningLabel, changeHandler);
connect(this, &QtQuickCompilerAspect::changed, this, changeHandler); connect(this, &QtQuickCompilerAspect::changed, warningLabel, changeHandler);
if (m_qmlDebuggingAspect) { if (m_qmlDebuggingAspect)
connect(m_qmlDebuggingAspect, &QmlDebuggingAspect::changed, this, connect(m_qmlDebuggingAspect, &QmlDebuggingAspect::changed, warningLabel, changeHandler);
changeHandler);
}
changeHandler(); changeHandler();
} }