Core: move CodecSelector dialog to Core

Task-number: QTCREATORBUG-23835
Change-Id: I824ae9650c244fffc064ade718fc788fc2908ada
Reviewed-by: hjk <hjk@qt.io>

src/plugins/coreplugin/CMakeLists.txt

@@ -18,6 +18,7 @@ add_qtc_plugin(Core
     coreplugin.cpp coreplugin.h
     designmode.cpp designmode.h
     dialogs/addtovcsdialog.cpp dialogs/addtovcsdialog.h dialogs/addtovcsdialog.ui
+    dialogs/codecselector.cpp dialogs/codecselector.h
     dialogs/externaltoolconfig.cpp dialogs/externaltoolconfig.h dialogs/externaltoolconfig.ui
     dialogs/filepropertiesdialog.cpp dialogs/filepropertiesdialog.h dialogs/filepropertiesdialog.ui
     dialogs/ioptionspage.cpp dialogs/ioptionspage.h

src/plugins/coreplugin/coreplugin.pro

@@ -112,7 +112,8 @@ SOURCES += corejsextensions.cpp \
     coreicons.cpp \
     diffservice.cpp \
     menubarfilter.cpp \
-    welcomepagehelper.cpp
+    welcomepagehelper.cpp \
+    dialogs/codecselector.cpp
 
 HEADERS += corejsextensions.h \
     mainwindow.h \
@@ -228,7 +229,8 @@ HEADERS += corejsextensions.h \
     diffservice.h \
     menubarfilter.h \
     editormanager/ieditorfactory_p.h \
-    welcomepagehelper.h
+    welcomepagehelper.h \
+    dialogs/codecselector.h
 
 FORMS += dialogs/newdialog.ui \
     dialogs/saveitemsdialog.ui \

src/plugins/coreplugin/coreplugin.qbs

@@ -208,6 +208,7 @@ Project {
             prefix: "dialogs/"
             files: [
                 "addtovcsdialog.cpp", "addtovcsdialog.h", "addtovcsdialog.ui",
+                "codecselector.cpp", "codecselector.h",
                 "externaltoolconfig.cpp", "externaltoolconfig.h", "externaltoolconfig.ui",
                 "filepropertiesdialog.cpp", "filepropertiesdialog.h", "filepropertiesdialog.ui",
                 "ioptionspage.cpp", "ioptionspage.h",

src/plugins/coreplugin/dialogs/codecselector.cpp

@@ -24,7 +24,7 @@
 ****************************************************************************/
 
 #include "codecselector.h"
-#include "textdocument.h"
+#include <coreplugin/textdocument.h>
 
 #include <utils/algorithm.h>
 #include <utils/fileutils.h>
@@ -36,11 +36,7 @@
 #include <QScrollBar>
 #include <QVBoxLayout>
 
-using namespace TextEditor;
+namespace Core {
-using namespace TextEditor::Internal;
-
-namespace TextEditor {
-namespace Internal {
 
 /* custom class to make sure the width is wide enough for the
  * contents. Should be easier with Qt. */
@@ -54,10 +50,6 @@ public:
     }
 };
 
-} // namespace Internal
-} // namespace TextEditor
-
-
 CodecSelector::CodecSelector(QWidget *parent, Core::BaseTextDocument *doc)
     : QDialog(parent)
 {
@@ -166,3 +158,4 @@ void CodecSelector::buttonClicked(QAbstractButton *button)
     done(result);
 }
 
+} // namespace Core

src/plugins/coreplugin/dialogs/codecselector.h

@@ -25,6 +25,8 @@
 
 #pragma once
 
+#include "../core_global.h"
+
 #include <QDialog>
 #include <QLabel>
 #include <QDialogButtonBox>
@@ -33,10 +35,9 @@
 namespace Utils { class ListWidget; }
 namespace Core { class BaseTextDocument; }
 
-namespace TextEditor {
+namespace Core {
-namespace Internal {
 
-class CodecSelector : public QDialog
+class CORE_EXPORT CodecSelector : public QDialog
 {
     Q_OBJECT
 
@@ -65,5 +66,4 @@ private:
     QAbstractButton *m_saveButton;
 };
 
-} // namespace Internal
+} // namespace Core
-} // namespace TextEditor

src/plugins/texteditor/CMakeLists.txt

@@ -34,7 +34,6 @@ add_qtc_plugin(TextEditor
     codeassist/runner.cpp codeassist/runner.h
     codeassist/textdocumentmanipulator.cpp codeassist/textdocumentmanipulator.h
     codeassist/textdocumentmanipulatorinterface.h
-    codecselector.cpp codecselector.h
     codestyleeditor.cpp codestyleeditor.h
     codestylepool.cpp codestylepool.h
     codestyleselectorwidget.cpp codestyleselectorwidget.h codestyleselectorwidget.ui

src/plugins/texteditor/texteditor.cpp

@@ -35,7 +35,6 @@
 #include "behaviorsettings.h"
 #include "circularclipboard.h"
 #include "circularclipboardassist.h"
-#include "codecselector.h"
 #include "completionsettings.h"
 #include "extraencodingsettings.h"
 #include "highlighter.h"
@@ -59,6 +58,7 @@
 #include <texteditor/codeassist/completionassistprovider.h>
 #include <texteditor/codeassist/documentcontentcompletion.h>
 
+#include <coreplugin/dialogs/codecselector.h>
 #include <coreplugin/icore.h>
 #include <aggregation/aggregate.h>
 #include <coreplugin/actionmanager/actionmanager.h>

src/plugins/texteditor/texteditor.pro

@@ -33,7 +33,6 @@ SOURCES += texteditorplugin.cpp \
     findinfiles.cpp \
     basefilefind.cpp \
     texteditorsettings.cpp \
-    codecselector.cpp \
     findincurrentfile.cpp \
     findinopenfiles.cpp \
     colorscheme.cpp \
@@ -120,7 +119,6 @@ HEADERS += texteditorplugin.h \
     findinfiles.h \
     basefilefind.h \
     texteditorsettings.h \
-    codecselector.h \
     findincurrentfile.h \
     findinopenfiles.h \
     colorscheme.h \

src/plugins/texteditor/texteditor.qbs

@@ -41,8 +41,6 @@ Project {
             "circularclipboard.h",
             "circularclipboardassist.cpp",
             "circularclipboardassist.h",
-            "codecselector.cpp",
-            "codecselector.h",
             "codestyleeditor.cpp",
             "codestyleeditor.h",
             "codestylepool.cpp",