feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlProfiler: Don't stop the RunControl from RunWorker dtor

Browse Source 
The QmlProfilerRunner is owned by its RunControl. It will only be
destroyed from the RunControl's dtor and therefore we don't need to stop
the RunControl at that point.

Furthermore, accessing the RunControl there is dangerous because it is
partially destroyed already.

Change-Id: I006e053bb9cd0da23cedb8fedfc46e049b72517d
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Ulf Hermann
2018-08-20 11:58:18 +02:00
parent 81d5d99db8
commit 5b2ac16011
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/qmlprofiler/qmlprofilerruncontrol.cpp
View File

@@ -83,8 +83,6 @@ QmlProfilerRunner::QmlProfilerRunner(RunControl *runControl)
QmlProfilerRunner::~QmlProfilerRunner() QmlProfilerRunner::~QmlProfilerRunner()
{ {
if (runControl()->isRunning() && d->m_profilerState)
runControl()->initiateStop();
delete d; delete d;
} }