feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Beautifier: Modernize, code style, and clean up

Browse Source 
Use nullptr and range based for loops, unify initializer list code
style, remove superfluous includes, make private slots private methods,
get rid of QLatin1(Char|String), use initializer lists and some minor
code style issues.

Change-Id: I94ba10fc96bb628239364a8201bde98a66b2c4c1
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
This commit is contained in:
Lorenz Haas
2016-04-21 21:08:57 +02:00
parent d25b88c304
commit 5b3f36184b
31 changed files with 345 additions and 447 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/plugins/beautifier/configurationpanel.cpp
View File

@@ -29,15 +29,12 @@
#include "abstractsettings.h"
#include "configurationdialog.h"
#include <QPointer>
namespace Beautifier {
namespace Internal {
ConfigurationPanel::ConfigurationPanel(QWidget *parent) :
QWidget(parent),
ui(new Ui::ConfigurationPanel),
m_settings(0)
ui(new Ui::ConfigurationPanel)
{
ui->setupUi(this);
connect(ui->add, &QPushButton::clicked, this, &ConfigurationPanel::add);
@@ -81,7 +78,7 @@ void ConfigurationPanel::add()
ConfigurationDialog dialog;
dialog.setWindowTitle(tr("Add Configuration"));
dialog.setSettings(m_settings);
if (QDialog::Accepted == dialog.exec()) {
if (dialog.exec() == QDialog::Accepted) {
const QString key = dialog.key();
m_settings->setStyle(key, dialog.value());
populateConfigurations(key);
@@ -95,7 +92,7 @@ void ConfigurationPanel::edit()
dialog.setWindowTitle(tr("Edit Configuration"));
dialog.setSettings(m_settings);
dialog.setKey(key);
if (QDialog::Accepted == dialog.exec()) {
if (dialog.exec() == QDialog::Accepted) {
const QString newKey = dialog.key();
if (newKey == key) {
m_settings->setStyle(key, dialog.value());
@@ -108,7 +105,7 @@ void ConfigurationPanel::edit()
void ConfigurationPanel::populateConfigurations(const QString &key)
{
ui->configurations->blockSignals(true);
const bool block = ui->configurations->blockSignals(true);
const QString currentText = (!key.isEmpty()) ? key : ui->configurations->currentText();
ui->configurations->clear();
ui->configurations->addItems(m_settings->styles());
@@ -116,14 +113,13 @@ void ConfigurationPanel::populateConfigurations(const QString &key)
if (textIndex != -1)
ui->configurations->setCurrentIndex(textIndex);
updateButtons();
ui->configurations->blockSignals(false);
ui->configurations->blockSignals(block);
}
void ConfigurationPanel::updateButtons()
{
const bool enabled
= ((ui->configurations->count() > 0)
&& !m_settings->styleIsReadOnly(ui->configurations->currentText()));
const bool enabled = ((ui->configurations->count() > 0)
&& !m_settings->styleIsReadOnly(ui->configurations->currentText()));
ui->remove->setEnabled(enabled);
ui->edit->setEnabled(enabled);
}