feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Nim: Restore init() override

Browse Source 
The usages if validate() disappeared in the following commits:
ec75575e64
0d185a0ad3

Restore a call to validate() from init() reimplementation.
Inline validate() body there.

Change-Id: I5999cc98345cd4d15138eb891c92d9bb9de00027
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Jarek Kobus
2025-02-06 13:49:15 +01:00
parent 0c29e5b3aa
commit 5b5423b442
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/nim/project/nimbletaskstep.cpp
View File

@@ -45,7 +45,7 @@ private:
void onDataChanged(const QModelIndex &topLeft, const QModelIndex &bottomRight, const QVector<int> &roles); void onDataChanged(const QModelIndex &topLeft, const QModelIndex &bottomRight, const QVector<int> &roles);
void uncheckedAllDifferentFrom(QStandardItem *item); void uncheckedAllDifferentFrom(QStandardItem *item);
bool validate(); bool init() override;
StringAspect m_taskName{this}; StringAspect m_taskName{this};
StringAspect m_taskArgs{this}; StringAspect m_taskArgs{this};
@@ -202,7 +202,7 @@ void NimbleTaskStep::setTaskName(const QString &name)
selectTask(name); selectTask(name);
} }
bool NimbleTaskStep::validate() bool NimbleTaskStep::init()
{ {
if (m_taskName().isEmpty()) if (m_taskName().isEmpty())
return true; return true;
@@ -217,8 +217,7 @@ bool NimbleTaskStep::validate()
emitFaultyConfigurationMessage(); emitFaultyConfigurationMessage();
return false; return false;
} }
return AbstractProcessStep::init();
return true;
} }
// Factory // Factory