From 5ba1ef9dbbf7c47f53424491cef1b1c30b8361e3 Mon Sep 17 00:00:00 2001 From: Eike Ziller Date: Fri, 26 Jul 2024 08:36:10 +0200 Subject: [PATCH] Meson/ToolWrapper: Fix missing initialization of m_isValid Amends a4a92a04a13e304330652b642793b3322509f1da Change-Id: Idab3141317729a6c2cf2ce0eaa1aa8c09ef1a1d7 Coverity-Id: 1598577 Reviewed-by: hjk --- src/plugins/mesonprojectmanager/mesontools.cpp | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/plugins/mesonprojectmanager/mesontools.cpp b/src/plugins/mesonprojectmanager/mesontools.cpp index b37f45830ee..5ab0d1f3923 100644 --- a/src/plugins/mesonprojectmanager/mesontools.cpp +++ b/src/plugins/mesonprojectmanager/mesontools.cpp @@ -27,12 +27,13 @@ static ToolType typeFromId(const QString &id) } ToolWrapper::ToolWrapper(const Store &data) + : ToolWrapper( + typeFromId(data.value(Constants::ToolsSettings::TOOL_TYPE_KEY).toString()), + data[Constants::ToolsSettings::NAME_KEY].toString(), + FilePath::fromSettings(data[Constants::ToolsSettings::EXE_KEY]), + Id::fromSetting(data[Constants::ToolsSettings::ID_KEY]), + data[Constants::ToolsSettings::AUTO_DETECTED_KEY].toBool()) { - m_toolType = typeFromId(data.value(Constants::ToolsSettings::TOOL_TYPE_KEY).toString()); - m_name = data[Constants::ToolsSettings::NAME_KEY].toString(); - m_exe = FilePath::fromSettings(data[Constants::ToolsSettings::EXE_KEY]); - m_id = Id::fromSetting(data[Constants::ToolsSettings::ID_KEY]); - m_autoDetected = data[Constants::ToolsSettings::AUTO_DETECTED_KEY].toBool(); } ToolWrapper::ToolWrapper(ToolType toolType,