feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Ssh: fix crash on freed memory access

Browse Source 
At the cleanup() method we must remove connection from the m_connection
list to avoid access to the freed memory from the
removeInactiveConnections() that caused Qt Creator crash.

Change-Id: I8195f05e903819e3e3b48b2f72fd71047c5a1636
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
Alexander Drozdov
2022-01-27 20:14:17 +10:00
parent 161d25571b
commit 5c53dc5e13
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/libs/ssh/sshconnectionmanager.cpp
View File

@@ -151,6 +151,7 @@ private:
disconnect(connection, nullptr, this, nullptr); disconnect(connection, nullptr, this, nullptr);
connection->deleteLater(); connection->deleteLater();
m_connections.erase(it);
} }
void removeInactiveConnections() void removeInactiveConnections()