feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Don't make engine type appear editable

Browse Source 
It is determined by the chosen debugger, no need for a combo box.

Change-Id: I1e278469bcd861a05eb102e94accee4dfc222b62
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
This commit is contained in:
hjk
2013-09-02 14:40:16 +02:00
parent 7f3a156778
commit 5c62a0f944
1 changed files with 1 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/plugins/debugger/debuggerkitconfigwidget.cpp
View File

@@ -1015,7 +1015,6 @@ public:
void saveItem(DebuggerItem *item); void saveItem(DebuggerItem *item);
private: private:
QLineEdit *m_displayNameLineEdit; QLineEdit *m_displayNameLineEdit;
QComboBox *m_engineTypeComboBox;
QLabel *m_cdbLabel; QLabel *m_cdbLabel;
PathChooser *m_binaryChooser; PathChooser *m_binaryChooser;
QLineEdit *m_abis; QLineEdit *m_abis;
@@ -1025,8 +1024,6 @@ DebuggerItemConfigWidget::DebuggerItemConfigWidget()
{ {
m_displayNameLineEdit = new QLineEdit(this); m_displayNameLineEdit = new QLineEdit(this);
m_engineTypeComboBox = new QComboBox(this);
m_binaryChooser = new PathChooser(this); m_binaryChooser = new PathChooser(this);
m_binaryChooser->setExpectedKind(PathChooser::ExistingCommand); m_binaryChooser->setExpectedKind(PathChooser::ExistingCommand);
m_binaryChooser->setMinimumWidth(400); m_binaryChooser->setMinimumWidth(400);
@@ -1038,15 +1035,9 @@ DebuggerItemConfigWidget::DebuggerItemConfigWidget()
m_abis = new QLineEdit(this); m_abis = new QLineEdit(this);
m_abis->setEnabled(false); m_abis->setEnabled(false);
QHBoxLayout *nameLayout = new QHBoxLayout;
nameLayout->addWidget(m_displayNameLineEdit);
nameLayout->addWidget(new QLabel(tr("Type:")));
nameLayout->addWidget(m_engineTypeComboBox);
QFormLayout *formLayout = new QFormLayout; QFormLayout *formLayout = new QFormLayout;
formLayout->setFieldGrowthPolicy(QFormLayout::AllNonFixedFieldsGrow); formLayout->setFieldGrowthPolicy(QFormLayout::AllNonFixedFieldsGrow);
formLayout->addRow(new QLabel(tr("Name:")), nameLayout); formLayout->addRow(new QLabel(tr("Name:")), m_displayNameLineEdit);
// formLayout->addRow(new QLabel(tr("Name:")), m_displayNameLineEdit);
// formLayout->addRow(new QLabel(tr("Type:")), m_engineTypeComboBox); // formLayout->addRow(new QLabel(tr("Type:")), m_engineTypeComboBox);
formLayout->addRow(m_cdbLabel); formLayout->addRow(m_cdbLabel);
formLayout->addRow(new QLabel(tr("Path:")), m_binaryChooser); formLayout->addRow(new QLabel(tr("Path:")), m_binaryChooser);
@@ -1063,12 +1054,6 @@ void DebuggerItemConfigWidget::loadItem(DebuggerItem *item)
m_displayNameLineEdit->setEnabled(!item->isAutoDetected); m_displayNameLineEdit->setEnabled(!item->isAutoDetected);
m_displayNameLineEdit->setText(item->displayName); m_displayNameLineEdit->setText(item->displayName);
// This is immutable.
m_engineTypeComboBox->clear();
m_engineTypeComboBox->addItem(item->engineTypeName());
m_engineTypeComboBox->setCurrentIndex(0);
//m_engineTypeComboBox->setEnabled(false);
m_binaryChooser->setEnabled(!item->isAutoDetected); m_binaryChooser->setEnabled(!item->isAutoDetected);
m_binaryChooser->setFileName(item->command); m_binaryChooser->setFileName(item->command);