diff --git a/src/plugins/genericprojectmanager/genericproject.cpp b/src/plugins/genericprojectmanager/genericproject.cpp index e0eb71afd36..c9f1f6d9737 100644 --- a/src/plugins/genericprojectmanager/genericproject.cpp +++ b/src/plugins/genericprojectmanager/genericproject.cpp @@ -461,7 +461,7 @@ GenericBuildSettingsWidget::GenericBuildSettingsWidget(GenericProject *project) fl->setFieldGrowthPolicy(QFormLayout::ExpandingFieldsGrow); // Configuration name - m_nameLineEdit = new QLineEdit(); + m_nameLineEdit = new QLineEdit; fl->addRow(tr("Configuration Name:"), m_nameLineEdit); connect(m_nameLineEdit, SIGNAL(textEdited(QString)), @@ -504,7 +504,7 @@ void GenericBuildSettingsWidget::init(BuildConfiguration *bc) m_pathChooser->setPath(m_buildConfiguration->buildDirectory()); } -void GenericBuildSettingsWidget::configNameEdited(QString name) +void GenericBuildSettingsWidget::configNameEdited(const QString &name) { m_buildConfiguration->setDisplayName(name); } diff --git a/src/plugins/genericprojectmanager/genericproject.h b/src/plugins/genericprojectmanager/genericproject.h index 49b6cadbe13..8c22dd94f5d 100644 --- a/src/plugins/genericprojectmanager/genericproject.h +++ b/src/plugins/genericprojectmanager/genericproject.h @@ -183,7 +183,7 @@ public: virtual void init(ProjectExplorer::BuildConfiguration *bc); private Q_SLOTS: - void configNameEdited(QString name); + void configNameEdited(const QString &name); void buildDirectoryChanged(); void toolChainSelected(int index); diff --git a/src/plugins/projectexplorer/buildconfiguration.cpp b/src/plugins/projectexplorer/buildconfiguration.cpp index b6b5f1fa904..bcfc3c63044 100644 --- a/src/plugins/projectexplorer/buildconfiguration.cpp +++ b/src/plugins/projectexplorer/buildconfiguration.cpp @@ -98,7 +98,7 @@ QVariantMap BuildConfiguration::toMap() const void BuildConfiguration::cloneSteps(BuildConfiguration *source) { Q_ASSERT(source); - foreach(BuildStep *originalbs, source->buildSteps()) { + foreach (BuildStep *originalbs, source->buildSteps()) { IBuildStepFactory *factory(findCloneFactory(this, originalbs)); if (!factory) continue; @@ -106,7 +106,7 @@ void BuildConfiguration::cloneSteps(BuildConfiguration *source) if (clonebs) m_buildSteps.append(clonebs); } - foreach(BuildStep *originalcs, source->cleanSteps()) { + foreach (BuildStep *originalcs, source->cleanSteps()) { IBuildStepFactory *factory = findCloneFactory(this, originalcs); if (!factory) continue;