From 5cc1aee7ff9f651835524e86c26414f4526a992a Mon Sep 17 00:00:00 2001 From: hjk Date: Mon, 25 Feb 2019 17:45:35 +0100 Subject: [PATCH] Qbs: Move QbsBaseProjectNode::showInSimpleTree() ... to QbsGroupNode::showInSimpleTree(). It's the only subclass that didn't re-implement it. It's easier to reason about the actual value when the value isn't flipped too often in the inheritance chain. Change-Id: I61f6020acc95a3dc0383b44ad8d40ee39f923d0f Reviewed-by: Christian Kandeler --- src/plugins/qbsprojectmanager/qbsnodes.cpp | 5 ----- src/plugins/qbsprojectmanager/qbsnodes.h | 2 -- 2 files changed, 7 deletions(-) diff --git a/src/plugins/qbsprojectmanager/qbsnodes.cpp b/src/plugins/qbsprojectmanager/qbsnodes.cpp index b5be80262de..91280dac418 100644 --- a/src/plugins/qbsprojectmanager/qbsnodes.cpp +++ b/src/plugins/qbsprojectmanager/qbsnodes.cpp @@ -258,11 +258,6 @@ QbsBaseProjectNode::QbsBaseProjectNode(const Utils::FileName &path) : ProjectExplorer::ProjectNode(path) { } -bool QbsBaseProjectNode::showInSimpleTree() const -{ - return false; -} - // -------------------------------------------------------------------- // QbsGroupNode: // -------------------------------------------------------------------- diff --git a/src/plugins/qbsprojectmanager/qbsnodes.h b/src/plugins/qbsprojectmanager/qbsnodes.h index 57077d15838..c1296ec5b2d 100644 --- a/src/plugins/qbsprojectmanager/qbsnodes.h +++ b/src/plugins/qbsprojectmanager/qbsnodes.h @@ -58,8 +58,6 @@ class QbsBaseProjectNode : public ProjectExplorer::ProjectNode { public: explicit QbsBaseProjectNode(const Utils::FileName &absoluteFilePath); - - bool showInSimpleTree() const override; }; // --------------------------------------------------------------------