feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Use a struct for toolchain autodetection parameters

Browse Source 
Also, make some functions const and use an alias for QList<ToolChain *>.

Change-Id: I6a1cbcb79bfaa9d252c4b69e00aa93e5d0dabe2f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2022-01-14 17:29:02 +01:00
parent 3749cfc896
commit 5cfe69b049
24 changed files with 262 additions and 296 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/plugins/projectexplorer/toolchain.cpp
View File

@@ -539,15 +539,13 @@ const QList<ToolChainFactory *> ToolChainFactory::allToolChainFactories()
return Internal::g_toolChainFactories;
}
QList<ToolChain *> ToolChainFactory::autoDetect(const QList<ToolChain *> &alreadyKnown,
const IDevice::Ptr &device)
Toolchains ToolChainFactory::autoDetect(const ToolchainDetector &detector) const
{
Q_UNUSED(alreadyKnown)
Q_UNUSED(device)
Q_UNUSED(detector)
return {};
}
QList<ToolChain *> ToolChainFactory::detectForImport(const ToolChainDescription &tcd)
Toolchains ToolChainFactory::detectForImport(const ToolChainDescription &tcd) const
{
Q_UNUSED(tcd)
return {};
@@ -558,7 +556,7 @@ bool ToolChainFactory::canCreate() const
return m_userCreatable;
}
ToolChain *ToolChainFactory::create()
ToolChain *ToolChainFactory::create() const
{
return m_toolchainConstructor ? m_toolchainConstructor() : nullptr;
}
@@ -650,4 +648,8 @@ void ToolChainFactory::setUserCreatable(bool userCreatable)
m_userCreatable = userCreatable;
}
ToolchainDetector::ToolchainDetector(const Toolchains &alreadyKnown, const IDevice::ConstPtr &device)
: alreadyKnown(alreadyKnown), device(device)
{}
} // namespace ProjectExplorer