From 5d0b5b35b20bb557660f336a6969dc79dd3bfe9c Mon Sep 17 00:00:00 2001 From: Orgad Shaneh Date: Wed, 6 Apr 2016 16:44:51 +0300 Subject: [PATCH] Debugger: Minor optimization in coredump lookup Change-Id: I162366ce98078ba49311c96772772258e3f3dcb7 Reviewed-by: hjk --- src/plugins/debugger/gdb/coregdbadapter.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/plugins/debugger/gdb/coregdbadapter.cpp b/src/plugins/debugger/gdb/coregdbadapter.cpp index fc6871c7032..bf6f1d41846 100644 --- a/src/plugins/debugger/gdb/coregdbadapter.cpp +++ b/src/plugins/debugger/gdb/coregdbadapter.cpp @@ -88,14 +88,14 @@ void GdbCoreEngine::setupEngine() static QString findExecutableFromName(const QString &fileNameFromCore, const QString &coreFile) { - if (QFileInfo(fileNameFromCore).isFile()) - return fileNameFromCore; if (fileNameFromCore.isEmpty()) - return QString(); + return fileNameFromCore; + QFileInfo fi(fileNameFromCore); + if (fi.isFile()) + return fileNameFromCore; // turn the filename into an absolute path, using the location of the core as a hint QString absPath; - QFileInfo fi(fileNameFromCore); if (fi.isAbsolute()) { absPath = fileNameFromCore; } else {