From 5d41ab126f84dccf9351deaeb296751aeb6ed8e3 Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Thu, 29 Feb 2024 17:22:57 +0100 Subject: [PATCH] ProjectExplorer: Expand selected details widgets in target setup page Rationale: - Selecting and unselecting should behave symmetrically. - The user is informed of and can easily change the set of pre-configured build configurations. Fixes: QTCREATORBUG-30412 Change-Id: I86e6a41c3baed280df9a694d6cf6eb631cb537f9 Reviewed-by: Qt CI Bot Reviewed-by: Reviewed-by: Marcus Tillmanns --- src/plugins/projectexplorer/targetsetupwidget.cpp | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/plugins/projectexplorer/targetsetupwidget.cpp b/src/plugins/projectexplorer/targetsetupwidget.cpp index 3ccf02b38de..0e2127706fb 100644 --- a/src/plugins/projectexplorer/targetsetupwidget.cpp +++ b/src/plugins/projectexplorer/targetsetupwidget.cpp @@ -103,6 +103,7 @@ void TargetSetupWidget::setKitSelected(bool b) b &= hasSelectedBuildConfigurations(); const GuardLocker locker(m_ignoreChanges); m_detailsWidget->setChecked(b); + m_detailsWidget->setState(b ? DetailsWidget::Expanded : DetailsWidget::Collapsed); m_detailsWidget->widget()->setEnabled(b); } @@ -168,12 +169,7 @@ void TargetSetupWidget::targetCheckBoxToggled(bool b) if (m_ignoreChanges.isLocked()) return; m_detailsWidget->widget()->setEnabled(b); - if (b && (contains(m_infoStore, &BuildInfoStore::hasIssues) - || !contains(m_infoStore, &BuildInfoStore::isEnabled))) { - m_detailsWidget->setState(DetailsWidget::Expanded); - } else if (!b) { - m_detailsWidget->setState(DetailsWidget::Collapsed); - } + m_detailsWidget->setState(b ? DetailsWidget::Expanded : DetailsWidget::Collapsed); emit selectedToggled(); }