feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProParser: Avoid the most common hard crash

Browse Source 
Whenever we try to access a non-local file we no more
hard crash Qt Creator, instead we silently handle it as
not found.

Change-Id: I3cbc617093c2a6fcb30626e276996430bb3795e5
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Christian Stenger
2021-07-23 11:20:08 +02:00
parent b8bcdd9568
commit 5d5969b46c
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/shared/proparser/ioutils.cpp
View File

@@ -60,6 +60,9 @@ IoUtils::FileType IoUtils::fileType(const QString &fileName)
return fileType(fileName.mid(pos)); return fileType(fileName.mid(pos));
} }
if (!QFileInfo::exists(fileName)) // FIXME make pro parser work with non-local
return FileNotFound;
Q_ASSERT(fileName.isEmpty() || isAbsolutePath(fileName)); Q_ASSERT(fileName.isEmpty() || isAbsolutePath(fileName));
#ifdef Q_OS_WIN #ifdef Q_OS_WIN
DWORD attr = GetFileAttributesW((WCHAR*)fileName.utf16()); DWORD attr = GetFileAttributesW((WCHAR*)fileName.utf16());