feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

genericprojectmanager: code cosmetic

Browse Source 
White space, namespaces, include order, comments, literal style,
remove unneded include/declarations etc.

Change-Id: Ifcb4371699c5cde244be1610b67cf81915cad2b2
Reviewed-by: hjk <qthjk@ovi.com>
This commit is contained in:
hjk
2012-08-14 15:37:38 +02:00
parent 588452663c
commit 5d5a483961
22 changed files with 266 additions and 288 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/plugins/genericprojectmanager/genericmakestep.h
View File

@@ -54,16 +54,15 @@ class GenericMakeStep : public ProjectExplorer::AbstractProcessStep
public:
GenericMakeStep(ProjectExplorer::BuildStepList *parent);
virtual ~GenericMakeStep();
~GenericMakeStep();
GenericBuildConfiguration *genericBuildConfiguration() const;
virtual bool init();
bool init();
void run(QFutureInterface<bool> &fi);
virtual void run(QFutureInterface<bool> &fi);
virtual ProjectExplorer::BuildStepConfigWidget *createConfigWidget();
virtual bool immutable() const;
ProjectExplorer::BuildStepConfigWidget *createConfigWidget();
bool immutable() const;
bool buildsTarget(const QString &target) const;
void setBuildTarget(const QString &target, bool on);
QString allArguments() const;
@@ -77,7 +76,7 @@ public:
protected:
GenericMakeStep(ProjectExplorer::BuildStepList *parent, GenericMakeStep *bs);
GenericMakeStep(ProjectExplorer::BuildStepList *parent, const Core::Id id);
virtual bool fromMap(const QVariantMap &map);
bool fromMap(const QVariantMap &map);
private:
void ctor();
@@ -88,20 +87,23 @@ private:
bool m_clean;
};
class GenericMakeStepConfigWidget :public ProjectExplorer::BuildStepConfigWidget
class GenericMakeStepConfigWidget : public ProjectExplorer::BuildStepConfigWidget
{
Q_OBJECT
public:
GenericMakeStepConfigWidget(GenericMakeStep *makeStep);
~GenericMakeStepConfigWidget();
virtual QString displayName() const;
virtual QString summaryText() const;
QString displayName() const;
QString summaryText() const;
private slots:
void itemChanged(QListWidgetItem*);
void itemChanged(QListWidgetItem *item);
void makeLineEditTextEdited();
void makeArgumentsLineEditTextEdited();
void updateMakeOverrrideLabel();
void updateDetails();
private:
Ui::GenericMakeStep *m_ui;
GenericMakeStep *m_makeStep;
@@ -114,7 +116,6 @@ class GenericMakeStepFactory : public ProjectExplorer::IBuildStepFactory
public:
explicit GenericMakeStepFactory(QObject *parent = 0);
~GenericMakeStepFactory();
bool canCreate(ProjectExplorer::BuildStepList *parent, const Core::Id id) const;
ProjectExplorer::BuildStep *create(ProjectExplorer::BuildStepList *parent, const Core::Id id);