From 5d69944ead7ccb3e207e3ad67b81ca10e56c9c49 Mon Sep 17 00:00:00 2001
From: hjk <hjk@qt.io>
Date: Wed, 28 Jun 2023 08:37:05 +0200
Subject: [PATCH] Qmake: More [[fallthrough]] warnings

Change-Id: I45acf2b2f6bd11a144786e076d87398d729fe2d8
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
---
 src/shared/proparser/qmakebuiltins.cpp  | 2 +-
 src/shared/proparser/qmakeevaluator.cpp | 4 ++--
 src/shared/proparser/qmakeparser.cpp    | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/shared/proparser/qmakebuiltins.cpp b/src/shared/proparser/qmakebuiltins.cpp
index 787d9effb9b..87707106e61 100644
--- a/src/shared/proparser/qmakebuiltins.cpp
+++ b/src/shared/proparser/qmakebuiltins.cpp
@@ -287,7 +287,7 @@ QMakeEvaluator::quoteValue(const ProString &val)
                 break;
             case 32:
                 quote = true;
-                // fallthrough
+                [[fallthrough]];
             default:
                 ret += c;
                 break;
diff --git a/src/shared/proparser/qmakeevaluator.cpp b/src/shared/proparser/qmakeevaluator.cpp
index e8d2ee32f16..0ea6c7f1334 100644
--- a/src/shared/proparser/qmakeevaluator.cpp
+++ b/src/shared/proparser/qmakeevaluator.cpp
@@ -1662,7 +1662,7 @@ QMakeEvaluator::VisitReturn QMakeEvaluator::expandVariableReferences(
                 tokPtr++;
                 continue;
             }
-            // fallthrough
+            [[fallthrough]];
         default:
             Q_ASSERT_X(false, "expandVariableReferences", "Unrecognized token");
             break;
@@ -2138,7 +2138,7 @@ QString QMakeEvaluator::formatValue(const ProString &val, bool forceQuote)
                 break;
             case 32:
                 quote = true;
-                // fallthrough
+                [[fallthrough]];
             default:
                 ret += c;
                 break;
diff --git a/src/shared/proparser/qmakeparser.cpp b/src/shared/proparser/qmakeparser.cpp
index 758a80ce4ac..0e8d888535e 100644
--- a/src/shared/proparser/qmakeparser.cpp
+++ b/src/shared/proparser/qmakeparser.cpp
@@ -1563,7 +1563,7 @@ static bool getBlock(const ushort *tokens, int limit, int &offset, QString *outS
             case TokRemove:
             case TokReplace:
                 // The parameter is the sizehint for the output.
-                // fallthrough
+                [[fallthrough]];
             case TokLine: {
                 ushort dummy;
                 ok = getUshort(tokens, limit, offset, &dummy, outStr);