From 5d79e1dcee768442efbb19c825ec6b50f03c441d Mon Sep 17 00:00:00 2001 From: hjk Date: Tue, 20 Mar 2018 08:05:19 +0100 Subject: [PATCH] Drop QFileInfo::exists() check before trying to run an executable Physical existence of a file is not strictly needed for something being runnable, e.g. 'foo' can be used to start a process on windows, even when only 'foo.exe', but not 'foo' itself exists. On the other hand, the existence of the file is not sufficient either to run it, so the check was too weak and too strict at the same time. Change-Id: I4a41d2f5cbb0cb471023a8bc23628072b28a5984 Reviewed-by: Ivan Donchevskii Reviewed-by: David Schulz --- src/plugins/projectexplorer/runconfiguration.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/plugins/projectexplorer/runconfiguration.cpp b/src/plugins/projectexplorer/runconfiguration.cpp index 5f91c9fa9dd..bf92088dfaf 100644 --- a/src/plugins/projectexplorer/runconfiguration.cpp +++ b/src/plugins/projectexplorer/runconfiguration.cpp @@ -1572,9 +1572,6 @@ void SimpleTargetRunner::start() const QString executable = m_runnable.as().executable; if (executable.isEmpty()) { reportFailure(RunControl::tr("No executable specified.")); - } else if (!QFileInfo::exists(executable)) { - reportFailure(RunControl::tr("Executable %1 does not exist.") - .arg(QDir::toNativeSeparators(executable))); } else { m_launcher.start(m_runnable); }