feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Clang: Remove the hint and snippet field from the CodeCompletion

Browse Source 
It is not used and is producing overhead.

Change-Id: I1398b18a40c0f5c0b90fe4c058996d7eb109f9f2
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
This commit is contained in:
Marco Bubke
2015-07-15 12:42:12 +02:00
parent 336501943e
commit 5df8085529
4 changed files with 0 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/libs/clangbackendipc/codecompletion.cpp
View File

@@ -38,15 +38,11 @@
namespace ClangBackEnd {
CodeCompletion::CodeCompletion(const Utf8String &text,
const Utf8String &hint,
const Utf8String &snippet,
quint32 priority,
Kind completionKind,
Availability availability,
bool hasParameters)
: text_(text),
hint_(hint),
snippet_(snippet),
priority_(priority),
completionKind_(completionKind),
availability_(availability),
@@ -63,15 +59,6 @@ const Utf8String &CodeCompletion::text() const
{
return text_;
}
const Utf8String &CodeCompletion::hint() const
{
return hint_;
}
const Utf8String &CodeCompletion::snippet() const
{
return snippet_;
}
void CodeCompletion::setCompletionKind(CodeCompletion::Kind completionKind)
{
@@ -136,8 +123,6 @@ quint32 &CodeCompletion::availabilityAsInt()
QDataStream &operator<<(QDataStream &out, const CodeCompletion &command)
{
out << command.text_;
out << command.hint_;
out << command.snippet_;
out << command.chunks_;
out << command.priority_;
out << command.completionKind_;
@@ -150,8 +135,6 @@ QDataStream &operator<<(QDataStream &out, const CodeCompletion &command)
QDataStream &operator>>(QDataStream &in, CodeCompletion &command)
{
in >> command.text_;
in >> command.hint_;
in >> command.snippet_;
in >> command.chunks_;
in >> command.priority_;
in >> command.completionKindAsInt();
@@ -213,8 +196,6 @@ QDebug operator<<(QDebug debug, const CodeCompletion &command)
debug.nospace() << "CodeCompletion(";
debug.nospace() << command.text_ << ", ";
debug.nospace() << command.hint_ << ", ";
debug.nospace() << command.snippet_ << ", ";
debug.nospace() << command.priority_ << ", ";
debug.nospace() << completionKindToString(command.completionKind_) << ", ";
debug.nospace() << availabilityToString(command.availability_) << ", ";
@@ -230,8 +211,6 @@ void PrintTo(const CodeCompletion &command, ::std::ostream* os)
*os << "CodeCompletion(";
*os << command.text_.constData() << ", ";
*os << command.hint_.constData() << ", ";
*os << command.snippet_.constData() << ", ";
*os << command.priority_ << ", ";
*os << completionKindToString(command.completionKind_) << ", ";
*os << availabilityToString(command.availability_) << ", ";