feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ClangCodeModel: Fix crash on git diff/show

Browse Source 
currentEditorChanged is emitted also for none TextEditors, so
check the qobject casted TextDocument before accessing it.

Change-Id: I57080221bec34b879f21e022029524818ea92569
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
David Schulz
2018-03-01 12:33:48 +01:00
parent 35efebf6f8
commit 5e2ad9457f
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/clangcodemodel/clangcurrentdocumentfilter.cpp
View File

@@ -176,11 +176,12 @@ void ClangCurrentDocumentFilter::onCurrentEditorChanged(Core::IEditor *newCurren
m_currentEditor = newCurrent; m_currentEditor = newCurrent;
Core::IDocument *document = m_currentEditor->document(); Core::IDocument *document = m_currentEditor->document();
QTC_ASSERT(document, return;); QTC_ASSERT(document, return;);
auto *textDocument = qobject_cast<TextEditor::TextDocument *>(document); if (auto *textDocument = qobject_cast<TextEditor::TextDocument *>(document)) {
m_currentPath = textDocument->filePath().toString(); m_currentPath = textDocument->filePath().toString();
} else { return;
reset();
} }
}
reset();
} }
} // namespace ClangCodeModel } // namespace ClangCodeModel