From 5e55c1e947c316ffca5a59c59cdff49eebc8f9bc Mon Sep 17 00:00:00 2001 From: hjk Date: Thu, 25 Jan 2018 14:33:14 +0100 Subject: [PATCH] Welcome: Detach Welcome page registration for global object pool We require individual pages to be provided in Plugin::initialize() Change-Id: I431112b523ed4cc803c07e5c6df8aa8d4ed1663b Reviewed-by: Eike Ziller --- src/plugins/welcome/welcomeplugin.cpp | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/plugins/welcome/welcomeplugin.cpp b/src/plugins/welcome/welcomeplugin.cpp index 9487e7a407f..b3c70ed984d 100644 --- a/src/plugins/welcome/welcomeplugin.cpp +++ b/src/plugins/welcome/welcomeplugin.cpp @@ -356,12 +356,6 @@ void WelcomeMode::initPlugins() for (IWelcomePage *page : IWelcomePage::allWelcomePages()) addPage(page); - // make sure later added pages are made available too: - connect(PluginManager::instance(), &PluginManager::objectAdded, this, [this](QObject *obj) { - if (IWelcomePage *page = qobject_cast(obj)) - addPage(page); - }); - if (!m_activePage.isValid() && !m_pageButtons.isEmpty()) { m_activePage = m_pluginList.at(0)->id(); m_pageButtons.at(0)->click();