diff --git a/src/plugins/scxmleditor/plugin_interface/connectableitem.cpp b/src/plugins/scxmleditor/plugin_interface/connectableitem.cpp index 5132f19038b..6fe6899fa31 100644 --- a/src/plugins/scxmleditor/plugin_interface/connectableitem.cpp +++ b/src/plugins/scxmleditor/plugin_interface/connectableitem.cpp @@ -64,15 +64,18 @@ ConnectableItem::~ConnectableItem() { setBlockUpdates(true); - for (ConnectableItem *item : qAsConst(m_overlappedItems)) + const QList overlappedItems = m_overlappedItems; + for (ConnectableItem *item : overlappedItems) item->removeOverlappingItem(this); m_overlappedItems.clear(); - for (TransitionItem *transition : qAsConst(m_outputTransitions)) + const QList outputTransitions = m_outputTransitions; + for (TransitionItem *transition : outputTransitions) transition->disconnectItem(this); m_outputTransitions.clear(); - for (TransitionItem *transition : qAsConst(m_inputTransitions)) + const QList inputTransitions = m_inputTransitions; + for (TransitionItem *transition : inputTransitions) transition->disconnectItem(this); m_inputTransitions.clear(); @@ -310,7 +313,8 @@ void ConnectableItem::updateTransitions(bool allChildren) updateInputTransitions(); if (allChildren) { - for (QGraphicsItem *it : childItems()) { + const QList items = childItems(); + for (QGraphicsItem *it : items) { auto item = static_cast(it); if (item && item->type() >= InitialStateType) item->updateTransitions(allChildren); diff --git a/src/plugins/scxmleditor/plugin_interface/scattributeitemdelegate.cpp b/src/plugins/scxmleditor/plugin_interface/scattributeitemdelegate.cpp index bd90d3f8463..365038a476a 100644 --- a/src/plugins/scxmleditor/plugin_interface/scattributeitemdelegate.cpp +++ b/src/plugins/scxmleditor/plugin_interface/scattributeitemdelegate.cpp @@ -80,7 +80,7 @@ void SCAttributeItemDelegate::setEditorData(QWidget *editor, const QModelIndex & combo->clear(); const QStringList values = index.data(DataRole).toString().split(";"); - for (QString val : values) + for (const QString &val : values) combo->addItem(val); combo->setCurrentText(index.data().toString());