feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Create a single parent options page for the Version Control category

Browse Source 
Cleans up some duplication for each page.

Reviewed-by: Friedemann Kleint
This commit is contained in:
Thorbjørn Lindeijer
2010-04-12 16:52:09 +02:00
parent f9051e6f87
commit 5e96fa3a91
17 changed files with 148 additions and 132 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/plugins/git/settingspage.cpp
View File

@@ -112,21 +112,6 @@ QString SettingsPage::displayName() const
return tr("Git");
}
QString SettingsPage::category() const
{
return QLatin1String(VCSBase::Constants::VCS_SETTINGS_CATEGORY);
}
QString SettingsPage::displayCategory() const
{
return QCoreApplication::translate("VCSBase", VCSBase::Constants::VCS_SETTINGS_TR_CATEGORY);
}
QIcon SettingsPage::categoryIcon() const
{
return QIcon(); // TODO: Icon for Version Control
}
QWidget *SettingsPage::createPage(QWidget *parent)
{
m_widget = new SettingsPageWidget(parent);

7
src/plugins/git/settingspage.h
View File

@@ -33,7 +33,7 @@
#include <QtGui/QWidget>
#include <QtCore/QPointer>
#include <coreplugin/dialogs/ioptionspage.h>
#include <vcsbase/vcsbaseoptionspage.h>
#include "ui_settingspage.h"
@@ -63,7 +63,7 @@ private:
Ui::SettingsPage m_ui;
};
class SettingsPage : public Core::IOptionsPage
class SettingsPage : public VCSBase::VCSBaseOptionsPage
{
Q_OBJECT
@@ -72,9 +72,6 @@ public:
QString id() const;
QString displayName() const;
QString category() const;
QString displayCategory() const;
QIcon categoryIcon() const;
QWidget *createPage(QWidget *parent);
void apply();