feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Create a single parent options page for the Version Control category

Browse Source 
Cleans up some duplication for each page.

Reviewed-by: Friedemann Kleint
This commit is contained in:
Thorbjørn Lindeijer
2010-04-12 16:52:09 +02:00
parent f9051e6f87
commit 5e96fa3a91
17 changed files with 148 additions and 132 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/plugins/vcsbase/commonsettingspage.cpp
View File

@@ -94,7 +94,7 @@ QString CommonSettingsWidget::searchKeyWordMatchString() const
// --------------- VCSBaseSettingsPage
CommonOptionsPage::CommonOptionsPage(QObject *parent) :
Core::IOptionsPage(parent)
VCSBaseOptionsPage(parent)
{
m_settings.fromSettings(Core::ICore::instance()->settings());
}
@@ -117,21 +117,6 @@ QString CommonOptionsPage::displayName() const
return QCoreApplication::translate("VCSBase", Constants::VCS_COMMON_SETTINGS_NAME);
}
QString CommonOptionsPage::category() const
{
return QLatin1String(Constants::VCS_SETTINGS_CATEGORY);
}
QString CommonOptionsPage::displayCategory() const
{
return QCoreApplication::translate("VCSBase", Constants::VCS_SETTINGS_TR_CATEGORY);
}
QIcon CommonOptionsPage::categoryIcon() const
{
return QIcon(); // TODO: Icon for Version Control
}
QWidget *CommonOptionsPage::createPage(QWidget *parent)
{
m_widget = new CommonSettingsWidget(parent);