From 5f1e6b15bf6d2af24ab4b5b500e6ba36a79600e7 Mon Sep 17 00:00:00 2001
From: Christian Kandeler <christian.kandeler@qt.io>
Date: Fri, 15 Oct 2021 12:55:12 +0200
Subject: [PATCH] LanguageClient: Only present snippets in addition to proper
 completions

Prevents spurious suggestions of snippets and is in line with what we
did for C++ so far.

Change-Id: I54e11b6567f00938f9aa7dfe771547471e87439c
Reviewed-by: David Schulz <david.schulz@qt.io>
---
 src/plugins/languageclient/languageclientcompletionassist.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/plugins/languageclient/languageclientcompletionassist.cpp b/src/plugins/languageclient/languageclientcompletionassist.cpp
index ca38029dc13..3eec6cbbd9d 100644
--- a/src/plugins/languageclient/languageclientcompletionassist.cpp
+++ b/src/plugins/languageclient/languageclientcompletionassist.cpp
@@ -425,7 +425,7 @@ void LanguageClientCompletionAssistProcessor::handleCompletionResponse(
         items = Utils::get<QList<CompletionItem>>(*result);
     }
     auto proposalItems = generateCompletionItems(items);
-    if (!m_snippetsGroup.isEmpty()) {
+    if (!proposalItems.isEmpty() && !m_snippetsGroup.isEmpty()) {
         proposalItems << TextEditor::SnippetAssistCollector(
                              m_snippetsGroup, QIcon(":/texteditor/images/snippet.png")).collect();
     }