From 5f5e82b0b6c9102b1f05caef04aa45ee51737b62 Mon Sep 17 00:00:00 2001 From: Alessandro Portale Date: Thu, 17 Jan 2019 02:03:19 +0100 Subject: [PATCH] Fix warning: "Don't call QList::front() on temporary" ..using constFirst, instead. [-Wclazy-detaching-temporary] Change-Id: I66bd9c19d56dc5dcc7ee0a1f68f4bfd2a3af7326 Reviewed-by: Thomas Hartmann --- src/plugins/debugger/stackhandler.cpp | 2 +- .../components/itemlibrary/itemlibraryresourceview.cpp | 2 +- src/plugins/vcsbase/vcsbasesubmiteditor.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/plugins/debugger/stackhandler.cpp b/src/plugins/debugger/stackhandler.cpp index e96f457ae6f..653ec7ec6c8 100644 --- a/src/plugins/debugger/stackhandler.cpp +++ b/src/plugins/debugger/stackhandler.cpp @@ -347,7 +347,7 @@ void StackHandler::saveTaskFile() while (!file.isOpen()) { if (fileDialog.exec() != QDialog::Accepted) return; - const QString fileName = fileDialog.selectedFiles().front(); + const QString fileName = fileDialog.selectedFiles().constFirst(); file.setFileName(fileName); if (!file.open(QIODevice::WriteOnly | QIODevice::Text)) { QString msg = tr("Cannot open \"%1\": %2") diff --git a/src/plugins/qmldesigner/components/itemlibrary/itemlibraryresourceview.cpp b/src/plugins/qmldesigner/components/itemlibrary/itemlibraryresourceview.cpp index abc70621c9a..ed522c42a5c 100644 --- a/src/plugins/qmldesigner/components/itemlibrary/itemlibraryresourceview.cpp +++ b/src/plugins/qmldesigner/components/itemlibrary/itemlibraryresourceview.cpp @@ -115,7 +115,7 @@ void ItemLibraryResourceView::startDrag(Qt::DropActions /* supportedActions */) auto fileSystemModel = qobject_cast(model()); Q_ASSERT(fileSystemModel); - QFileInfo fileInfo = fileSystemModel->fileInfo(selectedIndexes().front()); + QFileInfo fileInfo = fileSystemModel->fileInfo(selectedIndexes().constFirst()); QPixmap pixmap(fileInfo.absoluteFilePath()); if (!pixmap.isNull()) { auto drag = new QDrag(this); diff --git a/src/plugins/vcsbase/vcsbasesubmiteditor.cpp b/src/plugins/vcsbase/vcsbasesubmiteditor.cpp index 157d16cf3b2..6273e391e83 100644 --- a/src/plugins/vcsbase/vcsbasesubmiteditor.cpp +++ b/src/plugins/vcsbase/vcsbasesubmiteditor.cpp @@ -624,7 +624,7 @@ void VcsBaseSubmitEditor::slotInsertNickName() void VcsBaseSubmitEditor::slotSetFieldNickName(int i) { - if (SubmitFieldWidget *sfw = d->m_widget->submitFieldWidgets().front()) { + if (SubmitFieldWidget *sfw = d->m_widget->submitFieldWidgets().constFirst()) { const QString nick = promptForNickName(); if (!nick.isEmpty()) sfw->setFieldValue(i, nick);