feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

analyzer: don't crash on "Goto Next Leak" if there is none.

Browse Source 
Change-Id: I7829c7c93338fd4238b9148a9fed3be4f5f69687
Reviewed-by: con
Task-number: QTCREATORBUG-5386
Reviewed-on: http://codereview.qt.nokia.com/1427
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
This commit is contained in:
hjk
2011-07-11 14:56:57 +02:00
committed by Eike Ziller
parent bd92b51296
commit 5f65d79605
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/valgrind/memcheckerrorview.cpp
View File

@@ -509,11 +509,13 @@ void MemcheckErrorView::suppressError()
void MemcheckErrorView::goNext() void MemcheckErrorView::goNext()
{ {
QTC_ASSERT(rowCount(), return);
setCurrentRow((currentRow() + 1) % rowCount()); setCurrentRow((currentRow() + 1) % rowCount());
} }
void MemcheckErrorView::goBack() void MemcheckErrorView::goBack()
{ {
QTC_ASSERT(rowCount(), return);
const int prevRow = currentRow() - 1; const int prevRow = currentRow() - 1;
setCurrentRow(prevRow >= 0 ? prevRow : rowCount() - 1); setCurrentRow(prevRow >= 0 ? prevRow : rowCount() - 1);
} }

4
src/plugins/valgrind/memchecktool.cpp
View File

@@ -544,8 +544,8 @@ void MemcheckTool::updateErrorFilter()
void MemcheckTool::finished() void MemcheckTool::finished()
{ {
const int n = m_errorModel->rowCount(); const int n = m_errorModel->rowCount();
m_goBack->setEnabled(n > 0); m_goBack->setEnabled(n > 1);
m_goNext->setEnabled(n > 0); m_goNext->setEnabled(n > 1);
const QString msg = AnalyzerManager::msgToolFinished(displayName(), n); const QString msg = AnalyzerManager::msgToolFinished(displayName(), n);
AnalyzerManager::showStatusMessage(msg); AnalyzerManager::showStatusMessage(msg);
} }