forked from qt-creator/qt-creator
ValgrindRunner: Get rid of valgrindExecuted() signal
Use appendMessage() signal instead. Change-Id: I2beb70d1c9f59e6b8b3b1ad03ec7707d67aa50cd Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
@@ -37,14 +37,8 @@ ValgrindToolRunner::ValgrindToolRunner(RunControl *runControl)
|
|||||||
|
|
||||||
m_settings.fromMap(runControl->settingsData(ANALYZER_VALGRIND_SETTINGS));
|
m_settings.fromMap(runControl->settingsData(ANALYZER_VALGRIND_SETTINGS));
|
||||||
|
|
||||||
connect(&m_runner,
|
connect(&m_runner, &ValgrindRunner::appendMessage, this,
|
||||||
&ValgrindRunner::appendMessage,
|
|
||||||
this,
|
|
||||||
[this](const QString &msg, Utils::OutputFormat format) { appendMessage(msg, format); });
|
[this](const QString &msg, Utils::OutputFormat format) { appendMessage(msg, format); });
|
||||||
connect(&m_runner, &ValgrindRunner::valgrindExecuted,
|
|
||||||
this, [this](const QString &commandLine) {
|
|
||||||
appendMessage(commandLine, NormalMessageFormat);
|
|
||||||
});
|
|
||||||
connect(&m_runner, &ValgrindRunner::processErrorReceived,
|
connect(&m_runner, &ValgrindRunner::processErrorReceived,
|
||||||
this, &ValgrindToolRunner::receiveProcessError);
|
this, &ValgrindToolRunner::receiveProcessError);
|
||||||
connect(&m_runner, &ValgrindRunner::finished,
|
connect(&m_runner, &ValgrindRunner::finished,
|
||||||
|
@@ -156,7 +156,7 @@ bool ValgrindRunner::Private::run()
|
|||||||
|
|
||||||
cmd.addCommandLineAsArgs(m_debuggee.command);
|
cmd.addCommandLineAsArgs(m_debuggee.command);
|
||||||
|
|
||||||
emit q->valgrindExecuted(cmd.toUserOutput());
|
emit q->appendMessage(cmd.toUserOutput(), NormalMessageFormat);
|
||||||
|
|
||||||
m_process.setCommand(cmd);
|
m_process.setCommand(cmd);
|
||||||
m_process.setWorkingDirectory(m_debuggee.workingDirectory);
|
m_process.setWorkingDirectory(m_debuggee.workingDirectory);
|
||||||
|
@@ -44,10 +44,8 @@ public:
|
|||||||
|
|
||||||
signals:
|
signals:
|
||||||
void appendMessage(const QString &, Utils::OutputFormat);
|
void appendMessage(const QString &, Utils::OutputFormat);
|
||||||
|
|
||||||
void logMessageReceived(const QByteArray &);
|
void logMessageReceived(const QByteArray &);
|
||||||
void processErrorReceived(const QString &, QProcess::ProcessError);
|
void processErrorReceived(const QString &, QProcess::ProcessError);
|
||||||
void valgrindExecuted(const QString &);
|
|
||||||
void valgrindStarted(qint64 pid);
|
void valgrindStarted(qint64 pid);
|
||||||
void finished();
|
void finished();
|
||||||
|
|
||||||
|
Reference in New Issue
Block a user