feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

BinEditor: Remove BinEditor::modificationChanged() signal

Browse Source 
Was only used to trigger IEditor::changed(). Do that directly instead.

Change-Id: I6cc659ac9be9496dbf8b463660754dd8779db94c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2024-07-17 13:29:04 +02:00
parent a1eaaadbe9
commit 605aace7d7
1 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/plugins/bineditor/bineditorplugin.cpp
View File

@@ -160,7 +160,6 @@ public:
void redo();
signals:
void modificationChanged(bool modified);
void undoAvailable(bool);
void redoAvailable(bool);
void dataAdded();
@@ -604,7 +603,7 @@ void BinEditorDocument::setModified(bool modified)
if (unmodifiedState == m_unmodifiedState)
return;
m_unmodifiedState = unmodifiedState;
emit modificationChanged(m_undoStack.size() != m_unmodifiedState);
emit changed();
}
void BinEditorWidget::setReadOnly(bool readOnly)
@@ -1767,7 +1766,7 @@ void BinEditorDocument::changeData(qint64 position, uchar character, bool highNi
bool emitModificationChanged = (m_undoStack.size() == m_unmodifiedState);
m_undoStack.push(cmd);
if (emitModificationChanged)
emit modificationChanged(m_undoStack.size() != m_unmodifiedState);
emit changed();
if (m_undoStack.size() == 1)
emit undoAvailable(true);
@@ -1786,7 +1785,7 @@ void BinEditorDocument::undo()
m_redoStack.push(cmd);
emit cursorWanted(cmd.position);
if (emitModificationChanged)
emit modificationChanged(m_undoStack.size() != m_unmodifiedState);
emit changed();
if (m_undoStack.isEmpty())
emit undoAvailable(false);
if (m_redoStack.size() == 1)
@@ -1805,7 +1804,7 @@ void BinEditorDocument::redo()
m_undoStack.push(cmd);
emit cursorWanted(cmd.position + 1);
if (emitModificationChanged)
emit modificationChanged(m_undoStack.size() != m_unmodifiedState);
emit changed();
if (m_undoStack.size() == 1)
emit undoAvailable(true);
if (m_redoStack.isEmpty())
@@ -2242,8 +2241,6 @@ public:
connect(m_codecChooser, &CodecChooser::codecChanged,
widget, &BinEditorWidget::setCodec);
connect(m_document, &BinEditorDocument::modificationChanged,
m_document, &IDocument::changed);
const QVariant setting = ICore::settings()->value(Constants::C_ENCODING_SETTING);
if (!setting.isNull())
m_codecChooser->setAssignedCodec(QTextCodec::codecForName(setting.toByteArray()));