Core: Use override consistently

clang-tidy fixes from modernize-use-override check.

Change-Id: If33399d60e96cae766bbedbe30044ada411e862f
Reviewed-by: Eike Ziller <eike.ziller@qt.io>

src/plugins/coreplugin/actionmanager/actioncontainer_p.h

@@ -46,24 +46,24 @@ class ActionContainerPrivate : public ActionContainer
 
 public:
     ActionContainerPrivate(Id id);
-    ~ActionContainerPrivate() {}
+    ~ActionContainerPrivate() override {}
 
-    void setOnAllDisabledBehavior(OnAllDisabledBehavior behavior);
+    void setOnAllDisabledBehavior(OnAllDisabledBehavior behavior) override;
-    ActionContainer::OnAllDisabledBehavior onAllDisabledBehavior() const;
+    ActionContainer::OnAllDisabledBehavior onAllDisabledBehavior() const override;
 
-    QAction *insertLocation(Id groupId) const;
+    QAction *insertLocation(Id groupId) const override;
-    void appendGroup(Id id);
+    void appendGroup(Id id) override;
-    void insertGroup(Id before, Id groupId);
+    void insertGroup(Id before, Id groupId) override;
-    void addAction(Command *action, Id group = Id());
+    void addAction(Command *action, Id group = Id()) override;
-    void addMenu(ActionContainer *menu, Id group = Id());
+    void addMenu(ActionContainer *menu, Id group = Id()) override;
-    void addMenu(ActionContainer *before, ActionContainer *menu, Id group = Id());
+    void addMenu(ActionContainer *before, ActionContainer *menu, Id group = Id()) override;
-    Command *addSeparator(const Context &context, Id group = Id(), QAction **outSeparator = 0);
+    Command *addSeparator(const Context &context, Id group = Id(), QAction **outSeparator = 0) override;
-    virtual void clear();
+    void clear() override;
 
-    Id id() const;
+    Id id() const override;
 
-    QMenu *menu() const;
+    QMenu *menu() const override;
-    QMenuBar *menuBar() const;
+    QMenuBar *menuBar() const override;
 
     virtual void insertAction(QAction *before, QAction *action) = 0;
     virtual void insertMenu(QAction *before, QMenu *menu) = 0;
@@ -98,19 +98,19 @@ class MenuActionContainer : public ActionContainerPrivate
 {
 public:
     explicit MenuActionContainer(Id id);
-    ~MenuActionContainer();
+    ~MenuActionContainer() override;
 
-    QMenu *menu() const;
+    QMenu *menu() const override;
 
-    void insertAction(QAction *before, QAction *action);
+    void insertAction(QAction *before, QAction *action) override;
-    void insertMenu(QAction *before, QMenu *menu);
+    void insertMenu(QAction *before, QMenu *menu) override;
 
-    void removeAction(QAction *action);
+    void removeAction(QAction *action) override;
-    void removeMenu(QMenu *menu);
+    void removeMenu(QMenu *menu) override;
 
 protected:
-    bool canBeAddedToMenu() const;
+    bool canBeAddedToMenu() const override;
-    bool updateInternal();
+    bool updateInternal() override;
 
 private:
     QPointer<QMenu> m_menu;
@@ -122,17 +122,17 @@ public:
     explicit MenuBarActionContainer(Id id);
 
     void setMenuBar(QMenuBar *menuBar);
-    QMenuBar *menuBar() const;
+    QMenuBar *menuBar() const override;
 
-    void insertAction(QAction *before, QAction *action);
+    void insertAction(QAction *before, QAction *action) override;
-    void insertMenu(QAction *before, QMenu *menu);
+    void insertMenu(QAction *before, QMenu *menu) override;
 
-    void removeAction(QAction *action);
+    void removeAction(QAction *action) override;
-    void removeMenu(QMenu *menu);
+    void removeMenu(QMenu *menu) override;
 
 protected:
-    bool canBeAddedToMenu() const;
+    bool canBeAddedToMenu() const override;
-    bool updateInternal();
+    bool updateInternal() override;
 
 private:
     QMenuBar *m_menuBar;

src/plugins/coreplugin/actionmanager/actionmanager.h

@@ -80,7 +80,7 @@ signals:
 
 private:
     ActionManager(QObject *parent = 0);
-    ~ActionManager();
+    ~ActionManager() override;
     static void saveSettings();
     static void setContext(const Context &context);
 

src/plugins/coreplugin/actionmanager/actionmanager_p.h

@@ -49,7 +49,7 @@ public:
     typedef QHash<Id, Action *> IdCmdMap;
     typedef QHash<Id, ActionContainerPrivate *> IdContainerMap;
 
-    ~ActionManagerPrivate();
+    ~ActionManagerPrivate() override;
 
     void setContext(const Context &context);
     bool hasContext(int context) const;

src/plugins/coreplugin/actionmanager/command_p.h

@@ -47,35 +47,35 @@ class Action : public Command
 public:
     Action(Id id);
 
-    Id id() const;
+    Id id() const override;
 
-    void setDefaultKeySequence(const QKeySequence &key);
+    void setDefaultKeySequence(const QKeySequence &key) override;
-    QKeySequence defaultKeySequence() const;
+    QKeySequence defaultKeySequence() const override;
 
-    void setKeySequence(const QKeySequence &key);
+    void setKeySequence(const QKeySequence &key) override;
-    QKeySequence keySequence() const;
+    QKeySequence keySequence() const override;
 
-    void setDescription(const QString &text);
+    void setDescription(const QString &text) override;
-    QString description() const;
+    QString description() const override;
 
-    QAction *action() const;
+    QAction *action() const override;
 
-    QString stringWithAppendedShortcut(const QString &str) const;
+    QString stringWithAppendedShortcut(const QString &str) const override;
 
-    Context context() const;
+    Context context() const override;
     void setCurrentContext(const Context &context);
 
-    bool isActive() const;
+    bool isActive() const override;
     void addOverrideAction(QAction *action, const Context &context, bool scriptable);
     void removeOverrideAction(QAction *action);
     bool isEmpty() const;
 
-    bool isScriptable() const;
+    bool isScriptable() const override;
-    bool isScriptable(const Context &context) const;
+    bool isScriptable(const Context &context) const override;
 
-    void setAttribute(CommandAttribute attr);
+    void setAttribute(CommandAttribute attr) override;
-    void removeAttribute(CommandAttribute attr);
+    void removeAttribute(CommandAttribute attr) override;
-    bool hasAttribute(CommandAttribute attr) const;
+    bool hasAttribute(CommandAttribute attr) const override;
 
 private:
     void updateActiveState();

src/plugins/coreplugin/actionmanager/commandmappings.h

@@ -46,7 +46,7 @@ class CORE_EXPORT CommandMappings : public QWidget
 
 public:
     CommandMappings(QWidget *parent = 0);
-    ~CommandMappings();
+    ~CommandMappings() override;
 
 signals:
     void currentCommandChanged(QTreeWidgetItem *current);

src/plugins/coreplugin/basefilewizard.h

@@ -45,12 +45,12 @@ public:
     explicit BaseFileWizard(const BaseFileWizardFactory *factory, const QVariantMap &extraValues,
                             QWidget *parent = 0);
 
-    void initializePage(int id);
+    void initializePage(int id) override;
 
     QList<QWizardPage *> extensionPages();
 
-    void accept();
+    void accept() override;
-    void reject();
+    void reject() override;
 
 private:
     void generateFileList();

src/plugins/coreplugin/coreplugin.h

@@ -51,15 +51,15 @@ class CorePlugin : public ExtensionSystem::IPlugin
 
 public:
     CorePlugin();
-    ~CorePlugin();
+    ~CorePlugin() override;
 
-    bool initialize(const QStringList &arguments, QString *errorMessage = 0);
+    bool initialize(const QStringList &arguments, QString *errorMessage = 0) override;
-    void extensionsInitialized();
+    void extensionsInitialized() override;
-    bool delayedInitialize();
+    bool delayedInitialize() override;
-    ShutdownFlag aboutToShutdown();
+    ShutdownFlag aboutToShutdown() override;
     QObject *remoteCommand(const QStringList & /* options */,
                            const QString &workingDirectory,
-                           const QStringList &args);
+                           const QStringList &args) override;
 
 public slots:
     void fileOpenRequest(const QString&);

src/plugins/coreplugin/dialogs/addtovcsdialog.h

@@ -39,7 +39,7 @@ class AddToVcsDialog : public QDialog
 public:
     explicit AddToVcsDialog(QWidget *parent, const QString &title,
                             const QStringList &files, const QString &vcsDisplayName);
-    ~AddToVcsDialog();
+    ~AddToVcsDialog() override;
 
 private:
     Ui::AddToVcsDialog *ui;

src/plugins/coreplugin/dialogs/filepropertiesdialog.h

@@ -42,7 +42,7 @@ class FilePropertiesDialog : public QDialog
 
 public:
     explicit FilePropertiesDialog(const Utils::FileName &fileName, QWidget *parent = nullptr);
-    ~FilePropertiesDialog();
+    ~FilePropertiesDialog() override;
 
 private:
     void refresh();

src/plugins/coreplugin/dialogs/ioptionspage.h

@@ -45,7 +45,7 @@ class CORE_EXPORT IOptionsPage : public QObject
 
 public:
     IOptionsPage(QObject *parent = nullptr, bool registerGlobally = true);
-    virtual ~IOptionsPage();
+    ~IOptionsPage() override;
 
     static const QList<IOptionsPage *> allOptionsPages();
 
@@ -91,7 +91,7 @@ class CORE_EXPORT IOptionsPageProvider : public QObject
 
 public:
     IOptionsPageProvider(QObject *parent = nullptr);
-    ~IOptionsPageProvider();
+    ~IOptionsPageProvider() override;
 
     static const QList<IOptionsPageProvider *> allOptionsPagesProviders();
 

src/plugins/coreplugin/dialogs/newdialog.h

@@ -53,7 +53,7 @@ class NewDialog : public QDialog
 
 public:
     explicit NewDialog(QWidget *parent);
-    ~NewDialog();
+    ~NewDialog() override;
 
     void setWizardFactories(QList<IWizardFactory*> factories, const QString &defaultLocation, const QVariantMap &extraVariables);
 
@@ -63,13 +63,13 @@ public:
     static QWidget *currentDialog();
 
 protected:
-    bool event(QEvent *);
+    bool event(QEvent *) override;
 
 private:
     void currentCategoryChanged(const QModelIndex &);
     void currentItemChanged(const QModelIndex &);
-    void accept();
+    void accept() override;
-    void reject();
+    void reject() override;
     void updateOkButton();
     void setSelectedPlatform(const QString &platform);
 

src/plugins/coreplugin/dialogs/readonlyfilesdialog.h

@@ -67,12 +67,12 @@ public:
     explicit ReadOnlyFilesDialog(const QList<IDocument *> &documents,
                                  QWidget * parent = 0);
 
-    ~ReadOnlyFilesDialog();
+    ~ReadOnlyFilesDialog() override;
 
     void setMessage(const QString &message);
     void setShowFailWarning(bool show, const QString &warning = QString());
 
-    int exec();
+    int exec() override;
 
 private:
     friend class Internal::ReadOnlyFilesDialogPrivate;

src/plugins/coreplugin/dialogs/shortcutsettings.h

@@ -60,13 +60,13 @@ class ShortcutButton : public QPushButton
 public:
     ShortcutButton(QWidget *parent = 0);
 
-    QSize sizeHint() const;
+    QSize sizeHint() const override;
 
 signals:
     void keySequenceChanged(const QKeySequence &sequence);
 
 protected:
-    bool eventFilter(QObject *obj, QEvent *evt);
+    bool eventFilter(QObject *obj, QEvent *evt) override;
 
 private:
     void updateText();

src/plugins/coreplugin/documentmanager.h

@@ -157,11 +157,11 @@ signals:
     void projectsDirectoryChanged(const Utils::FileName &directory);
 
 protected:
-    bool eventFilter(QObject *obj, QEvent *e);
+    bool eventFilter(QObject *obj, QEvent *e) override;
 
 private:
     explicit DocumentManager(QObject *parent);
-    ~DocumentManager();
+    ~DocumentManager() override;
 
     void documentDestroyed(QObject *obj);
     void checkForNewFileName();

src/plugins/coreplugin/editormanager/editorarea.h

@@ -41,7 +41,7 @@ class EditorArea : public SplitterOrView
 
 public:
     EditorArea();
-    ~EditorArea();
+    ~EditorArea() override;
 
     IDocument *currentDocument() const;
 

src/plugins/coreplugin/editormanager/editormanager.h

@@ -202,7 +202,7 @@ public slots:
 
 private:
     explicit EditorManager(QObject *parent);
-    ~EditorManager();
+    ~EditorManager() override;
 
     friend class Core::Internal::MainWindow;
 };

src/plugins/coreplugin/editormanager/editormanager_p.h

@@ -203,7 +203,7 @@ private:
 
 private:
     explicit EditorManagerPrivate(QObject *parent);
-    ~EditorManagerPrivate();
+    ~EditorManagerPrivate() override;
     void init();
 
     QList<EditLocation> m_globalHistory;

src/plugins/coreplugin/editormanager/editorview.h

@@ -73,7 +73,7 @@ class EditorView : public QWidget
 
 public:
     explicit EditorView(SplitterOrView *parentSplitterOrView, QWidget *parent = nullptr);
-    virtual ~EditorView();
+    ~EditorView() override;
 
     SplitterOrView *parentSplitterOrView() const;
     EditorView *findNextView();
@@ -104,9 +104,9 @@ signals:
     void currentEditorChanged(Core::IEditor *editor);
 
 protected:
-    void paintEvent(QPaintEvent *);
+    void paintEvent(QPaintEvent *) override;
-    void mousePressEvent(QMouseEvent *e);
+    void mousePressEvent(QMouseEvent *e) override;
-    void focusInEvent(QFocusEvent *);
+    void focusInEvent(QFocusEvent *) override;
 
 private:
     friend class SplitterOrView; // for setParentSplitterOrView
@@ -169,7 +169,7 @@ class SplitterOrView  : public QWidget
 public:
     explicit SplitterOrView(IEditor *editor = nullptr);
     explicit SplitterOrView(EditorView *view);
-    ~SplitterOrView();
+    ~SplitterOrView() override;
 
     void split(Qt::Orientation orientation);
     void unsplit();
@@ -193,8 +193,8 @@ public:
     EditorView *findLastView();
     SplitterOrView *findParentSplitter() const;
 
-    QSize sizeHint() const { return minimumSizeHint(); }
+    QSize sizeHint() const override { return minimumSizeHint(); }
-    QSize minimumSizeHint() const;
+    QSize minimumSizeHint() const override;
 
     void unsplitAll();
 

src/plugins/coreplugin/editormanager/ieditorfactory.h

@@ -41,7 +41,7 @@ class CORE_EXPORT IEditorFactory : public QObject
 
 public:
     IEditorFactory(QObject *parent = nullptr);
-    ~IEditorFactory();
+    ~IEditorFactory() override;
 
     static const QList<IEditorFactory *> allEditorFactories();
 

src/plugins/coreplugin/editormanager/iexternaleditor.h

@@ -39,7 +39,7 @@ class CORE_EXPORT IExternalEditor : public QObject
 
 public:
     explicit IExternalEditor(QObject *parent = nullptr);
-    ~IExternalEditor();
+    ~IExternalEditor() override;
 
     static const QList<IExternalEditor *> allExternalEditors();
 

src/plugins/coreplugin/editortoolbar.h

@@ -51,7 +51,7 @@ class CORE_EXPORT EditorToolBar : public Utils::StyledBar
 
 public:
     explicit EditorToolBar(QWidget *parent = 0);
-    virtual ~EditorToolBar();
+    ~EditorToolBar() override;
 
     typedef std::function<void(QMenu*)> MenuProvider;
     enum ToolbarCreationFlags { FlagsNone = 0, FlagsStandalone = 1 };
@@ -94,7 +94,7 @@ signals:
     void currentDocumentMoved();
 
 protected:
-    bool eventFilter(QObject *obj, QEvent *event);
+    bool eventFilter(QObject *obj, QEvent *event) override;
 
 private:
     void changeActiveEditor(int row);

src/plugins/coreplugin/externaltool.h

@@ -52,7 +52,7 @@ public:
 
     ExternalTool();
     explicit ExternalTool(const ExternalTool *other);
-    ~ExternalTool();
+    ~ExternalTool() override;
 
     QString id() const;
     QString description() const;
@@ -123,7 +123,7 @@ class ExternalToolRunner : public QObject
     Q_OBJECT
 public:
     ExternalToolRunner(const ExternalTool *tool);
-    ~ExternalToolRunner();
+    ~ExternalToolRunner() override;
 
     bool hasError() const;
     QString errorString() const;

src/plugins/coreplugin/externaltoolmanager.h

@@ -42,7 +42,7 @@ class CORE_EXPORT ExternalToolManager : public QObject
 
 public:
     ExternalToolManager();
-    ~ExternalToolManager();
+    ~ExternalToolManager() override;
 
     static ExternalToolManager *instance();
     static QMap<QString, QList<Internal::ExternalTool *> > toolsByCategory();

src/plugins/coreplugin/find/basetextfind.h

@@ -43,25 +43,25 @@ class CORE_EXPORT BaseTextFind : public IFindSupport
 public:
     explicit BaseTextFind(QPlainTextEdit *editor);
     explicit BaseTextFind(QTextEdit *editor);
-    virtual ~BaseTextFind();
+    ~BaseTextFind() override;
 
-    bool supportsReplace() const;
+    bool supportsReplace() const override;
-    FindFlags supportedFindFlags() const;
+    FindFlags supportedFindFlags() const override;
-    void resetIncrementalSearch();
+    void resetIncrementalSearch() override;
-    void clearHighlights();
+    void clearHighlights() override;
-    QString currentFindString() const;
+    QString currentFindString() const override;
-    QString completedFindString() const;
+    QString completedFindString() const override;
 
-    Result findIncremental(const QString &txt, FindFlags findFlags);
+    Result findIncremental(const QString &txt, FindFlags findFlags) override;
-    Result findStep(const QString &txt, FindFlags findFlags);
+    Result findStep(const QString &txt, FindFlags findFlags) override;
-    void replace(const QString &before, const QString &after, FindFlags findFlags);
+    void replace(const QString &before, const QString &after, FindFlags findFlags) override;
-    bool replaceStep(const QString &before, const QString &after, FindFlags findFlags);
+    bool replaceStep(const QString &before, const QString &after, FindFlags findFlags) override;
-    int replaceAll(const QString &before, const QString &after, FindFlags findFlags);
+    int replaceAll(const QString &before, const QString &after, FindFlags findFlags) override;
 
-    void defineFindScope();
+    void defineFindScope() override;
-    void clearFindScope();
+    void clearFindScope() override;
 
-    void highlightAll(const QString &txt, FindFlags findFlags);
+    void highlightAll(const QString &txt, FindFlags findFlags) override;
 
 signals:
     void highlightAllRequested(const QString &txt, Core::FindFlags findFlags);

src/plugins/coreplugin/find/ifindfilter.h

@@ -42,7 +42,7 @@ class CORE_EXPORT IFindFilter : public QObject
 
 public:
     IFindFilter();
-    virtual ~IFindFilter();
+    ~IFindFilter() override;
 
     static const QList<IFindFilter *> allFindFilters();
 

src/plugins/coreplugin/find/ifindsupport.h

@@ -40,7 +40,7 @@ public:
     enum Result { Found, NotFound, NotYetFound };
 
     IFindSupport() : QObject(0) {}
-    virtual ~IFindSupport() {}
+    ~IFindSupport() override {}
 
     virtual bool supportsReplace() const = 0;
     virtual FindFlags supportedFindFlags() const = 0;

src/plugins/coreplugin/find/itemviewfind.h

@@ -52,18 +52,18 @@ public:
 
     explicit ItemViewFind(QAbstractItemView *view, int role = Qt::DisplayRole,
             FetchOption option = DoNotFetchMoreWhileSearching);
-    virtual ~ItemViewFind();
+    ~ItemViewFind() override;
 
-    bool supportsReplace() const;
+    bool supportsReplace() const override;
-    FindFlags supportedFindFlags() const;
+    FindFlags supportedFindFlags() const override;
-    void resetIncrementalSearch();
+    void resetIncrementalSearch() override;
-    void clearHighlights();
+    void clearHighlights() override;
-    QString currentFindString() const;
+    QString currentFindString() const override;
-    QString completedFindString() const;
+    QString completedFindString() const override;
 
-    virtual void highlightAll(const QString &txt, FindFlags findFlags);
+    void highlightAll(const QString &txt, FindFlags findFlags) override;
-    Result findIncremental(const QString &txt, FindFlags findFlags);
+    Result findIncremental(const QString &txt, FindFlags findFlags) override;
-    Result findStep(const QString &txt, FindFlags findFlags);
+    Result findStep(const QString &txt, FindFlags findFlags) override;
 
     static QFrame *createSearchableWrapper(QAbstractItemView *treeView, ColorOption colorOption = DarkColored,
                                            FetchOption option = DoNotFetchMoreWhileSearching);

src/plugins/coreplugin/find/searchresultwindow.h

@@ -115,24 +115,24 @@ public:
 
 
     SearchResultWindow(QWidget *newSearchPanel);
-    virtual ~SearchResultWindow();
+    ~SearchResultWindow() override;
     static SearchResultWindow *instance();
 
-    QWidget *outputWidget(QWidget *);
+    QWidget *outputWidget(QWidget *) override;
-    QList<QWidget*> toolBarWidgets() const;
+    QList<QWidget*> toolBarWidgets() const override;
 
-    QString displayName() const { return tr("Search Results"); }
+    QString displayName() const override { return tr("Search Results"); }
-    int priorityInStatusBar() const;
+    int priorityInStatusBar() const override;
-    void visibilityChanged(bool visible);
+    void visibilityChanged(bool visible) override;
-    bool hasFocus() const;
+    bool hasFocus() const override;
-    bool canFocus() const;
+    bool canFocus() const override;
-    void setFocus();
+    void setFocus() override;
 
-    bool canNext() const;
+    bool canNext() const override;
-    bool canPrevious() const;
+    bool canPrevious() const override;
-    void goToNext();
+    void goToNext() override;
-    void goToPrev();
+    void goToPrev() override;
-    bool canNavigate() const;
+    bool canNavigate() const override;
 
     void setTextEditorFont(const QFont &font,
                            const QColor &textForegroundColor,
@@ -154,7 +154,7 @@ public:
                                  const QString &cfgGroup = QString());
 
 public slots:
-    void clearContents();
+    void clearContents() override;
 
 public: // Used by plugin, do not use
     void writeSettings();

src/plugins/coreplugin/findplaceholder.h

@@ -38,7 +38,7 @@ class CORE_EXPORT FindToolBarPlaceHolder : public QWidget
     Q_OBJECT
 public:
     explicit FindToolBarPlaceHolder(QWidget *owner, QWidget *parent = 0);
-    ~FindToolBarPlaceHolder();
+    ~FindToolBarPlaceHolder() override;
 
     static const QList<FindToolBarPlaceHolder *> allFindToolbarPlaceHolders();
 

src/plugins/coreplugin/helpmanager.h

@@ -103,7 +103,7 @@ signals:
 
 private:
     explicit HelpManager(QObject *parent = nullptr);
-    ~HelpManager();
+    ~HelpManager() override;
 
     static void setupHelpManager();
     static void registerDocumentationNow(QFutureInterface<bool> &futureInterface,

src/plugins/coreplugin/icore.h

@@ -58,7 +58,7 @@ class CORE_EXPORT ICore : public QObject
     friend class IWizardFactory;
 
     explicit ICore(Internal::MainWindow *mw);
-    ~ICore();
+    ~ICore() override;
 
 public:
     enum class ContextPriority {

src/plugins/coreplugin/idocumentfactory.h

@@ -42,7 +42,7 @@ class CORE_EXPORT IDocumentFactory : public QObject
 
 public:
     IDocumentFactory(QObject *parent = nullptr);
-    ~IDocumentFactory();
+    ~IDocumentFactory() override;
 
     static const QList<IDocumentFactory *> allDocumentFactories();
 

src/plugins/coreplugin/ifilewizardextension.h

@@ -49,7 +49,7 @@ class CORE_EXPORT IFileWizardExtension : public QObject
     Q_OBJECT
 public:
     IFileWizardExtension();
-    ~IFileWizardExtension();
+    ~IFileWizardExtension() override;
     static QList<IFileWizardExtension *> allFileWizardExtensions();
 
     /* Return a list of pages to be added to the Wizard (empty list if not

src/plugins/coreplugin/imode.h

@@ -40,7 +40,7 @@ class CORE_EXPORT IMode : public IContext
 
 public:
     IMode(QObject *parent = 0);
-    ~IMode();
+    ~IMode() override;
 
     QString displayName() const { return m_displayName; }
     QIcon icon() const { return m_icon; }

src/plugins/coreplugin/inavigationwidgetfactory.h

@@ -53,7 +53,7 @@ class CORE_EXPORT INavigationWidgetFactory : public QObject
 
 public:
     INavigationWidgetFactory();
-    ~INavigationWidgetFactory();
+    ~INavigationWidgetFactory() override;
 
     static const QList<INavigationWidgetFactory *> allNavigationFactories();
 

src/plugins/coreplugin/ioutputpane.h

@@ -43,7 +43,7 @@ class CORE_EXPORT IOutputPane : public QObject
 
 public:
     IOutputPane(QObject *parent = nullptr);
-    ~IOutputPane();
+    ~IOutputPane() override;
 
     virtual QWidget *outputWidget(QWidget *parent) = 0;
     virtual QList<QWidget *> toolBarWidgets() const = 0;

src/plugins/coreplugin/iversioncontrol.h

@@ -87,7 +87,7 @@ public:
     };
 
     explicit IVersionControl(TopicCache *topicCache = 0) : m_topicCache(topicCache) {}
-    virtual ~IVersionControl();
+    ~IVersionControl() override;
 
     virtual QString displayName() const = 0;
     virtual Id id() const = 0;
@@ -243,7 +243,7 @@ public:
     TestVersionControl(Id id, const QString &name) :
         m_id(id), m_displayName(name), m_dirCount(0), m_fileCount(0)
     { }
-    ~TestVersionControl();
+    ~TestVersionControl() override;
 
     bool isVcsFileOrDirectory(const Utils::FileName &fileName) const final
     { Q_UNUSED(fileName); return false; }

src/plugins/coreplugin/iwelcomepage.h

@@ -49,7 +49,7 @@ class CORE_EXPORT IWelcomePage : public QObject
 
 public:
     IWelcomePage();
-    virtual ~IWelcomePage();
+    ~IWelcomePage() override;
 
     virtual QString title() const = 0;
     virtual int priority() const { return 0; }
@@ -73,7 +73,7 @@ class CORE_EXPORT WelcomePageButton : public WelcomePageFrame
 {
 public:
     WelcomePageButton(QWidget *parent);
-    ~WelcomePageButton();
+    ~WelcomePageButton() override;
 
     void mousePressEvent(QMouseEvent *) override;
     void enterEvent(QEvent *) override;

src/plugins/coreplugin/locator/basefilefilter.h

@@ -54,11 +54,11 @@ public:
         ListIterator(const QStringList &filePaths);
         ListIterator(const QStringList &filePaths, const QStringList &fileNames);
 
-        void toFront();
+        void toFront() override;
-        bool hasNext() const;
+        bool hasNext() const override;
-        QString next();
+        QString next() override;
-        QString filePath() const;
+        QString filePath() const override;
-        QString fileName() const;
+        QString fileName() const override;
 
     private:
         QStringList m_filePaths;
@@ -68,7 +68,7 @@ public:
     };
 
     BaseFileFilter();
-    ~BaseFileFilter();
+    ~BaseFileFilter() override;
     void prepareSearch(const QString &entry) override;
     QList<LocatorFilterEntry> matchesFor(QFutureInterface<LocatorFilterEntry> &future,
                                          const QString &entry) override;

src/plugins/coreplugin/locator/commandlocator.h

@@ -41,7 +41,7 @@ class CORE_EXPORT CommandLocator : public ILocatorFilter
 public:
     CommandLocator(Id id, const QString &displayName,
                    const QString &shortCutString, QObject *parent = nullptr);
-    ~CommandLocator();
+    ~CommandLocator() override;
 
     void appendCommand(Command *cmd);
 

src/plugins/coreplugin/locator/ilocatorfilter.h

@@ -108,7 +108,7 @@ public:
     enum Priority {Highest = 0, High = 1, Medium = 2, Low = 3};
 
     ILocatorFilter(QObject *parent = nullptr);
-    virtual ~ILocatorFilter();
+    ~ILocatorFilter() override;
 
     static const QList<ILocatorFilter *> allLocatorFilters();
 

src/plugins/coreplugin/locator/locator.h

@@ -45,7 +45,7 @@ class Locator : public QObject
 
 public:
     Locator();
-    ~Locator();
+    ~Locator() override;
 
     static Locator *instance();
 

src/plugins/coreplugin/mainwindow.h

@@ -76,7 +76,7 @@ class MainWindow : public Utils::AppMainWindow
 
 public:
     MainWindow();
-    ~MainWindow();
+    ~MainWindow() override;
 
     void init();
     void extensionsInitialized();
@@ -112,7 +112,7 @@ public slots:
     void exit();
 
 protected:
-    virtual void closeEvent(QCloseEvent *event);
+    void closeEvent(QCloseEvent *event) override;
 
 private:
     void openFile();

src/plugins/coreplugin/manhattanstyle.h

@@ -38,33 +38,33 @@ class CORE_EXPORT ManhattanStyle : public QProxyStyle
 public:
     explicit ManhattanStyle(const QString &baseStyleName);
 
-    ~ManhattanStyle();
+    ~ManhattanStyle() override;
 
-    void drawPrimitive(PrimitiveElement element, const QStyleOption *option, QPainter *painter, const QWidget *widget = 0) const;
+    void drawPrimitive(PrimitiveElement element, const QStyleOption *option, QPainter *painter, const QWidget *widget = 0) const override;
-    void drawControl(ControlElement element, const QStyleOption *option, QPainter *painter, const QWidget *widget = 0) const;
+    void drawControl(ControlElement element, const QStyleOption *option, QPainter *painter, const QWidget *widget = 0) const override;
-    void drawComplexControl(ComplexControl control, const QStyleOptionComplex *option, QPainter *painter, const QWidget *widget = 0) const;
+    void drawComplexControl(ComplexControl control, const QStyleOptionComplex *option, QPainter *painter, const QWidget *widget = 0) const override;
 
-    QSize sizeFromContents(ContentsType type, const QStyleOption *option, const QSize &size, const QWidget *widget) const;
+    QSize sizeFromContents(ContentsType type, const QStyleOption *option, const QSize &size, const QWidget *widget) const override;
-    QRect subElementRect(SubElement element, const QStyleOption *option, const QWidget *widget) const;
+    QRect subElementRect(SubElement element, const QStyleOption *option, const QWidget *widget) const override;
-    QRect subControlRect(ComplexControl cc, const QStyleOptionComplex *opt, SubControl sc, const QWidget *widget) const;
+    QRect subControlRect(ComplexControl cc, const QStyleOptionComplex *opt, SubControl sc, const QWidget *widget) const override;
 
-    SubControl hitTestComplexControl(ComplexControl control, const QStyleOptionComplex *option, const QPoint &pos, const QWidget *widget = 0) const;
+    SubControl hitTestComplexControl(ComplexControl control, const QStyleOptionComplex *option, const QPoint &pos, const QWidget *widget = 0) const override;
-    QPixmap standardPixmap(StandardPixmap standardPixmap, const QStyleOption *opt, const QWidget *widget = 0) const;
+    QPixmap standardPixmap(StandardPixmap standardPixmap, const QStyleOption *opt, const QWidget *widget = 0) const override;
-    QIcon standardIcon(StandardPixmap standardIcon, const QStyleOption *option = 0, const QWidget *widget = 0) const;
+    QIcon standardIcon(StandardPixmap standardIcon, const QStyleOption *option = 0, const QWidget *widget = 0) const override;
-    int styleHint(StyleHint hint, const QStyleOption *option = 0, const QWidget *widget = 0, QStyleHintReturn *returnData = 0) const;
+    int styleHint(StyleHint hint, const QStyleOption *option = 0, const QWidget *widget = 0, QStyleHintReturn *returnData = 0) const override;
     QRect itemRect(QPainter *p, const QRect &r, int flags, bool enabled, const QPixmap *pixmap, const QString &text, int len = -1) const;
-    QPixmap generatedIconPixmap(QIcon::Mode iconMode, const QPixmap &pixmap, const QStyleOption *opt) const;
+    QPixmap generatedIconPixmap(QIcon::Mode iconMode, const QPixmap &pixmap, const QStyleOption *opt) const override;
 
-    int pixelMetric(PixelMetric metric, const QStyleOption *option = 0, const QWidget *widget = 0) const;
+    int pixelMetric(PixelMetric metric, const QStyleOption *option = 0, const QWidget *widget = 0) const override;
 
-    QPalette standardPalette() const;
+    QPalette standardPalette() const override;
 
-    void polish(QWidget *widget);
+    void polish(QWidget *widget) override;
-    void polish(QPalette &pal);
+    void polish(QPalette &pal) override;
-    void polish(QApplication *app);
+    void polish(QApplication *app) override;
 
-    void unpolish(QWidget *widget);
+    void unpolish(QWidget *widget) override;
-    void unpolish(QApplication *app);
+    void unpolish(QApplication *app) override;
 
 private:
     void drawButtonSeparator(QPainter *painter, const QRect &rect, bool reverse) const;

src/plugins/coreplugin/messagemanager.h

@@ -61,7 +61,7 @@ public slots:
 
 private:
     MessageManager();
-    ~MessageManager();
+    ~MessageManager() override;
     static void init();
     friend class Core::Internal::MainWindow;
 };

src/plugins/coreplugin/minisplitter.h

@@ -45,7 +45,7 @@ public:
     MiniSplitter(Qt::Orientation orientation, SplitterStyle style = Dark);
 
 protected:
-    QSplitterHandle *createHandle();
+    QSplitterHandle *createHandle() override;
 
 private:
     SplitterStyle m_style;
@@ -57,7 +57,7 @@ public:
     explicit NonResizingSplitter(QWidget *parent, SplitterStyle style = Light);
 
 protected:
-    void resizeEvent(QResizeEvent *ev);
+    void resizeEvent(QResizeEvent *ev) override;
 };
 
 

src/plugins/coreplugin/modemanager.h

@@ -68,7 +68,7 @@ signals:
 
 private:
     explicit ModeManager(Internal::MainWindow *mainWindow, Internal::FancyTabWidget *modeStack);
-    ~ModeManager();
+    ~ModeManager() override;
 
     static void extensionsInitialized();
 

src/plugins/coreplugin/navigationwidget.h

@@ -54,7 +54,7 @@ class CORE_EXPORT NavigationWidgetPlaceHolder : public QWidget
 
 public:
     explicit NavigationWidgetPlaceHolder(Id mode, Side side, QWidget *parent = 0);
-    virtual ~NavigationWidgetPlaceHolder();
+    ~NavigationWidgetPlaceHolder() override;
     static NavigationWidgetPlaceHolder *current(Side side);
     static void setCurrent(Side side, NavigationWidgetPlaceHolder *navWidget);
     void applyStoredSize();
@@ -81,7 +81,7 @@ public:
     };
 
     explicit NavigationWidget(QAction *toggleSideBarAction, Side side);
-    virtual ~NavigationWidget();
+    ~NavigationWidget() override;
 
     void setFactories(const QList<INavigationWidgetFactory*> &factories);
 
@@ -107,7 +107,7 @@ public:
     QAbstractItemModel *factoryModel() const;
 
 protected:
-    void resizeEvent(QResizeEvent *);
+    void resizeEvent(QResizeEvent *) override;
 
 private:
     void splitSubWidget(int factoryIndex);

src/plugins/coreplugin/opendocumentstreeview.h

@@ -38,14 +38,14 @@ class CORE_EXPORT OpenDocumentsTreeView : public Utils::TreeView
 public:
     explicit OpenDocumentsTreeView(QWidget *parent = 0);
 
-    void setModel(QAbstractItemModel *model);
+    void setModel(QAbstractItemModel *model) override;
     void setCloseButtonVisible(bool visible);
 
 signals:
     void closeActivated(const QModelIndex &index);
 
 protected:
-    bool eventFilter(QObject *obj, QEvent *event);
+    bool eventFilter(QObject *obj, QEvent *event) override;
 
 private:
     Internal::OpenDocumentsDelegate *m_delegate;

src/plugins/coreplugin/outputpane.h

@@ -43,7 +43,7 @@ class CORE_EXPORT OutputPanePlaceHolder : public QWidget
 
 public:
     explicit OutputPanePlaceHolder(Id mode, QSplitter *parent = 0);
-    ~OutputPanePlaceHolder();
+    ~OutputPanePlaceHolder() override;
 
     static OutputPanePlaceHolder *getCurrent();
     static bool isCurrentVisible();
@@ -54,8 +54,8 @@ public:
     int nonMaximizedSize() const;
 
 protected:
-    void resizeEvent(QResizeEvent *event);
+    void resizeEvent(QResizeEvent *event) override;
-    void showEvent(QShowEvent *);
+    void showEvent(QShowEvent *) override;
 
 private:
     void setHeight(int height);

src/plugins/coreplugin/outputpanemanager.h

@@ -65,7 +65,7 @@ public slots:
     void toggleMaximized();
 
 protected:
-    void focusInEvent(QFocusEvent *e);
+    void focusInEvent(QFocusEvent *e) override;
 
 private:
     // the only class that is allowed to create and destroy
@@ -76,7 +76,7 @@ private:
     static void destroy();
 
     explicit OutputPaneManager(QWidget *parent = 0);
-    ~OutputPaneManager();
+    ~OutputPaneManager() override;
 
     void shortcutTriggered(int idx);
     void clearPage();
@@ -137,14 +137,14 @@ class OutputPaneToggleButton : public QToolButton
 public:
     OutputPaneToggleButton(int number, const QString &text, QAction *action,
                            QWidget *parent = 0);
-    QSize sizeHint() const;
+    QSize sizeHint() const override;
-    void paintEvent(QPaintEvent*);
+    void paintEvent(QPaintEvent*) override;
     void flash(int count = 3);
     void setIconBadgeNumber(int number);
 
 private:
     void updateToolTip();
-    void checkStateSet();
+    void checkStateSet() override;
 
     QString m_number;
     QString m_text;
@@ -158,8 +158,8 @@ class OutputPaneManageButton : public QToolButton
     Q_OBJECT
 public:
     OutputPaneManageButton();
-    QSize sizeHint() const;
+    QSize sizeHint() const override;
-    void paintEvent(QPaintEvent*);
+    void paintEvent(QPaintEvent*) override;
 };
 
 } // namespace Internal

src/plugins/coreplugin/outputwindow.h

@@ -46,7 +46,7 @@ class CORE_EXPORT OutputWindow : public QPlainTextEdit
 
 public:
     OutputWindow(Context context, QWidget *parent = 0);
-    ~OutputWindow();
+    ~OutputWindow() override;
 
     Utils::OutputFormatter *formatter() const;
     void setFormatter(Utils::OutputFormatter *formatter);

src/plugins/coreplugin/progressmanager/futureprogress.h

@@ -46,9 +46,9 @@ public:
         KeepOnFinish = 2
     };
     explicit FutureProgress(QWidget *parent = 0);
-    virtual ~FutureProgress();
+    ~FutureProgress() override;
 
-    virtual bool eventFilter(QObject *object, QEvent *);
+    bool eventFilter(QObject *object, QEvent *) override;
 
     void setFuture(const QFuture<void> &future);
     QFuture<void> future() const;
@@ -72,7 +72,7 @@ public:
 
     bool isFading() const;
 
-    QSize sizeHint() const;
+    QSize sizeHint() const override;
 
 signals:
     void clicked();
@@ -85,8 +85,8 @@ signals:
     void statusBarWidgetChanged();
 
 protected:
-    void mousePressEvent(QMouseEvent *event);
+    void mousePressEvent(QMouseEvent *event) override;
-    void paintEvent(QPaintEvent *);
+    void paintEvent(QPaintEvent *) override;
 
 private:
     void updateToolTip(const QString &);

src/plugins/coreplugin/progressmanager/progressmanager.h

@@ -66,7 +66,7 @@ signals:
 
 private:
     ProgressManager();
-    ~ProgressManager();
+    ~ProgressManager() override;
 
     friend class Core::Internal::ProgressManagerPrivate;
 };

src/plugins/coreplugin/progressmanager/progressmanager_p.h

@@ -49,7 +49,7 @@ class ProgressManagerPrivate : public Core::ProgressManager
     Q_OBJECT
 public:
     ProgressManagerPrivate();
-    ~ProgressManagerPrivate();
+    ~ProgressManagerPrivate() override;
     void init();
     void cleanup();
 
@@ -63,7 +63,7 @@ public slots:
     void doCancelTasks(Core::Id type);
 
 protected:
-    bool eventFilter(QObject *obj, QEvent *event);
+    bool eventFilter(QObject *obj, QEvent *event) override;
 
 private:
     void taskFinished();
@@ -115,8 +115,8 @@ class ToggleButton : public QToolButton
     Q_OBJECT
 public:
     ToggleButton(QWidget *parent);
-    QSize sizeHint() const;
+    QSize sizeHint() const override;
-    void paintEvent(QPaintEvent *event);
+    void paintEvent(QPaintEvent *event) override;
 };
 
 } // namespace Internal

src/plugins/coreplugin/progressmanager/progressview.h

@@ -44,7 +44,7 @@ class ProgressView : public QWidget
 
 public:
     ProgressView(QWidget *parent = 0);
-    ~ProgressView();
+    ~ProgressView() override;
 
     void addProgressWidget(QWidget *widget);
     void removeProgressWidget(QWidget *widget);
@@ -54,8 +54,8 @@ public:
     void setReferenceWidget(QWidget *widget);
 
 protected:
-    bool event(QEvent *event);
+    bool event(QEvent *event) override;
-    bool eventFilter(QObject *obj, QEvent *event);
+    bool eventFilter(QObject *obj, QEvent *event) override;
 
 signals:
     void hoveredChanged(bool hovered);

src/plugins/coreplugin/reaper_p.h

@@ -41,7 +41,7 @@ class ProcessReaper : public QObject
 
 public:
     ProcessReaper(QProcess *p, int timeoutMs);
-    ~ProcessReaper();
+    ~ProcessReaper() override;
 
     int timeoutMs() const;
     bool isFinished() const;

src/plugins/coreplugin/rightpane.h

@@ -45,7 +45,7 @@ class CORE_EXPORT RightPanePlaceHolder : public QWidget
 
 public:
     explicit RightPanePlaceHolder(Id mode, QWidget *parent = 0);
-    ~RightPanePlaceHolder();
+    ~RightPanePlaceHolder() override;
     static RightPanePlaceHolder *current();
 
 private:
@@ -61,7 +61,7 @@ class CORE_EXPORT RightPaneWidget : public QWidget
 
 public:
     RightPaneWidget();
-    ~RightPaneWidget();
+    ~RightPaneWidget() override;
 
     void saveSettings(QSettings *settings);
     void readSettings(QSettings *settings);
@@ -76,7 +76,7 @@ public:
     int storedWidth();
 
 protected:
-    void resizeEvent(QResizeEvent *);
+    void resizeEvent(QResizeEvent *) override;
 
 private:
     void clearWidget();

src/plugins/coreplugin/settingsdatabase.h

@@ -40,7 +40,7 @@ class CORE_EXPORT SettingsDatabase : public QObject
 {
 public:
     SettingsDatabase(const QString &path, const QString &application, QObject *parent = 0);
-    ~SettingsDatabase();
+    ~SettingsDatabase() override;
 
     void setValue(const QString &key, const QVariant &value);
     QVariant value(const QString &key, const QVariant &defaultValue = QVariant()) const;

src/plugins/coreplugin/shellcommand.h

@@ -39,7 +39,7 @@ public:
     ShellCommand(const QString &workingDirectory, const QProcessEnvironment &environment);
 
 protected:
-    void addTask(QFuture<void> &future);
+    void addTask(QFuture<void> &future) override;
 
     virtual void coreAboutToClose();
 };

src/plugins/coreplugin/sidebar.h

@@ -56,7 +56,7 @@ class CORE_EXPORT SideBarItem : public QObject
 public:
     // id is non-localized string of the item that's used to store the settings.
     explicit SideBarItem(QWidget *widget, const QString &id);
-    virtual ~SideBarItem();
+    ~SideBarItem() override;
 
     QWidget *widget() const;
     QString id() const;
@@ -86,7 +86,7 @@ public:
      * of multiple SideBars.
      */
     SideBar(QList<SideBarItem *> widgetList, QList<SideBarItem *> defaultVisible);
-    virtual ~SideBar();
+    ~SideBar() override;
 
     QStringList availableItemIds() const;
     QStringList availableItemTitles() const;

src/plugins/coreplugin/themechooser.h

@@ -63,7 +63,7 @@ class ThemeChooser : public QWidget
 
 public:
     ThemeChooser(QWidget *parent = 0);
-    ~ThemeChooser();
+    ~ThemeChooser() override;
 
     void apply();
 

src/plugins/coreplugin/variablechooser.h

@@ -42,7 +42,7 @@ class CORE_EXPORT VariableChooser : public QWidget
 
 public:
     explicit VariableChooser(QWidget *parent = 0);
-    ~VariableChooser();
+    ~VariableChooser() override;
 
     void addMacroExpanderProvider(const Utils::MacroExpanderProvider &provider);
     void addSupportedWidget(QWidget *textcontrol, const QByteArray &ownName = QByteArray());
@@ -50,8 +50,8 @@ public:
     static void addSupportForChildWidgets(QWidget *parent, Utils::MacroExpander *expander);
 
 protected:
-    bool event(QEvent *ev);
+    bool event(QEvent *ev) override;
-    bool eventFilter(QObject *, QEvent *event);
+    bool eventFilter(QObject *, QEvent *event) override;
 
 private:
     Internal::VariableChooserPrivate *d;

src/plugins/coreplugin/vcsmanager.h

@@ -108,7 +108,7 @@ signals:
 
 private:
     explicit VcsManager(QObject *parent = 0);
-    ~VcsManager();
+    ~VcsManager() override;
 
     static void addVersionControl(IVersionControl *vc);