feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CMakePM: clang-tidy fix for "performance-unnecessary-value-param"

Browse Source 
Change-Id: Ia22d7c3fe6c29a5e0999145b6c4b281818dd72bf
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This commit is contained in:
Cristian Adam
2023-10-20 14:42:46 +02:00
parent 73d0c4a29d
commit 60de12efd2
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/cmakeprojectmanager/cmakebuildconfiguration.cpp
View File

@@ -1098,7 +1098,7 @@ static bool isWindowsARM64(const Kit *k)
&& targetAbi.wordWidth() == 64; && targetAbi.wordWidth() == 64;
} }
static CommandLine defaultInitialCMakeCommand(const Kit *k, const QString buildType) static CommandLine defaultInitialCMakeCommand(const Kit *k, const QString &buildType)
{ {
// Generator: // Generator:
CMakeTool *tool = CMakeKitAspect::cmakeTool(k); CMakeTool *tool = CMakeKitAspect::cmakeTool(k);

2
src/plugins/cmakeprojectmanager/cmaketool.cpp
View File

@@ -656,7 +656,7 @@ void CMakeTool::fetchFromCapabilities(bool ignoreCache) const
QTC_ASSERT_EXPECTED(result, return); QTC_ASSERT_EXPECTED(result, return);
} }
static int getVersion(const QVariantMap &obj, const QString value) static int getVersion(const QVariantMap &obj, const QString &value)
{ {
bool ok; bool ok;
int result = obj.value(value).toInt(&ok); int result = obj.value(value).toInt(&ok);