Header cleanup in TextEditor.

Change-Id: I832d255a4d8f291426d54ad0353641db515a511a
Reviewed-on: http://codereview.qt.nokia.com/3182
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
This commit is contained in:
Friedemann Kleint
2011-08-18 14:23:06 +02:00
parent 2a3684fb2f
commit 610f77ed33
19 changed files with 39 additions and 28 deletions

View File

@@ -72,6 +72,10 @@ BaseFileFind::BaseFileFind(SearchResultWindow *resultWindow)
connect(&m_watcher, SIGNAL(finished()), this, SLOT(searchFinished())); connect(&m_watcher, SIGNAL(finished()), this, SLOT(searchFinished()));
} }
BaseFileFind::~BaseFileFind()
{
}
bool BaseFileFind::isEnabled() const bool BaseFileFind::isEnabled() const
{ {
return !m_isSearching; return !m_isSearching;

View File

@@ -36,23 +36,26 @@
#include "texteditor_global.h" #include "texteditor_global.h"
#include <find/ifindfilter.h> #include <find/ifindfilter.h>
#include <find/ifindsupport.h>
#include <find/searchresultwindow.h> #include <find/searchresultwindow.h>
#include <utils/filesearch.h> #include <utils/filesearch.h>
#include <QtGui/QStringListModel>
#include <QtCore/QFutureWatcher> #include <QtCore/QFutureWatcher>
#include <QtCore/QPointer> #include <QtCore/QPointer>
#include <QtGui/QStringListModel>
QT_BEGIN_NAMESPACE QT_BEGIN_NAMESPACE
class QLabel; class QLabel;
class QComboBox; class QComboBox;
QT_END_NAMESPACE QT_END_NAMESPACE
namespace Utils {
class FileIterator;
}
namespace Find { namespace Find {
class SearchResultWindow; class SearchResultWindow;
struct SearchResultItem; struct SearchResultItem;
class IFindSupport;
} }
namespace TextEditor { namespace TextEditor {
@@ -63,6 +66,7 @@ class TEXTEDITOR_EXPORT BaseFileFind : public Find::IFindFilter
public: public:
explicit BaseFileFind(Find::SearchResultWindow *resultWindow); explicit BaseFileFind(Find::SearchResultWindow *resultWindow);
~BaseFileFind();
bool isEnabled() const; bool isEnabled() const;
bool canCancel() const; bool canCancel() const;

View File

@@ -52,6 +52,7 @@
#include "defaultassistinterface.h" #include "defaultassistinterface.h"
#include "convenience.h" #include "convenience.h"
#include "texteditorsettings.h" #include "texteditorsettings.h"
#include "texteditoroverlay.h"
#include <aggregation/aggregate.h> #include <aggregation/aggregate.h>
#include <coreplugin/actionmanager/actionmanager.h> #include <coreplugin/actionmanager/actionmanager.h>

View File

@@ -37,7 +37,6 @@
#include "codeassist/assistenums.h" #include "codeassist/assistenums.h"
#include <find/ifindsupport.h> #include <find/ifindsupport.h>
#include <coreplugin/editormanager/editormanager.h> #include <coreplugin/editormanager/editormanager.h>
#include <QtGui/QPlainTextEdit> #include <QtGui/QPlainTextEdit>

View File

@@ -36,7 +36,6 @@
#include "basetexteditor.h" #include "basetexteditor.h"
#include "behaviorsettings.h" #include "behaviorsettings.h"
#include "displaysettings.h" #include "displaysettings.h"
#include "texteditoroverlay.h"
#include "fontsettings.h" #include "fontsettings.h"
#include "refactoroverlay.h" #include "refactoroverlay.h"
@@ -47,9 +46,6 @@
#include <QtCore/QPointer> #include <QtCore/QPointer>
#include <QtCore/QScopedPointer> #include <QtCore/QScopedPointer>
#include <QtGui/QPixmap>
#include <QtGui/QTextEdit>
namespace TextEditor { namespace TextEditor {
class BaseTextDocument; class BaseTextDocument;
@@ -57,6 +53,7 @@ class TextEditorActionHandler;
class CodeAssistant; class CodeAssistant;
namespace Internal { namespace Internal {
class TextEditorOverlay;
class TEXTEDITOR_EXPORT BaseTextBlockSelection class TEXTEDITOR_EXPORT BaseTextBlockSelection
{ {

View File

@@ -37,7 +37,6 @@
#include "itexteditor.h" #include "itexteditor.h"
#include <QtCore/QPointer> #include <QtCore/QPointer>
#include <QtGui/QIcon>
QT_BEGIN_NAMESPACE QT_BEGIN_NAMESPACE
class QTextBlock; class QTextBlock;

View File

@@ -35,7 +35,7 @@
#include "texteditor_global.h" #include "texteditor_global.h"
#include <QtCore/QVariant> #include <QtCore/QVariantMap>
QT_BEGIN_NAMESPACE QT_BEGIN_NAMESPACE
class QSettings; class QSettings;

View File

@@ -33,6 +33,8 @@
#include "codestylepreferencesmanager.h" #include "codestylepreferencesmanager.h"
#include "icodestylepreferencesfactory.h" #include "icodestylepreferencesfactory.h"
#include <QtCore/QMap>
using namespace TextEditor; using namespace TextEditor;
CodeStylePreferencesManager *CodeStylePreferencesManager::m_instance = 0; CodeStylePreferencesManager *CodeStylePreferencesManager::m_instance = 0;

View File

@@ -36,7 +36,6 @@
#include "texteditor_global.h" #include "texteditor_global.h"
#include <QtCore/QObject> #include <QtCore/QObject>
#include <QtCore/QVariant>
namespace TextEditor { namespace TextEditor {

View File

@@ -34,6 +34,7 @@
#include <QtGui/QTextDocument> #include <QtGui/QTextDocument>
#include <QtGui/QTextBlock> #include <QtGui/QTextBlock>
#include <QtGui/QTextCursor>
namespace TextEditor { namespace TextEditor {
namespace Convenience { namespace Convenience {

View File

@@ -35,13 +35,13 @@
#include "texteditor_global.h" #include "texteditor_global.h"
#include <QtCore/QString>
QT_BEGIN_NAMESPACE QT_BEGIN_NAMESPACE
class QTextDocument; class QTextDocument;
class QTextCursor;
QT_END_NAMESPACE QT_END_NAMESPACE
#include <QtCore/QString>
#include <QtGui/QTextCursor>
namespace TextEditor { namespace TextEditor {
namespace Convenience { namespace Convenience {

View File

@@ -35,7 +35,7 @@
#include "texteditor_global.h" #include "texteditor_global.h"
#include <QtCore/QVariant> #include <QtCore/QVariantMap>
QT_BEGIN_NAMESPACE QT_BEGIN_NAMESPACE
class QSettings; class QSettings;

View File

@@ -36,7 +36,6 @@
#include "texteditor_global.h" #include "texteditor_global.h"
#include <QtGui/QWidget> #include <QtGui/QWidget>
#include <QtCore/QMap>
QT_BEGIN_NAMESPACE QT_BEGIN_NAMESPACE
class QHBoxLayout; class QHBoxLayout;

View File

@@ -37,9 +37,6 @@
#include <utils/uncommentselection.h> #include <utils/uncommentselection.h>
#include <QtCore/QList>
#include <QtCore/QScopedPointer>
namespace Core { namespace Core {
class MimeType; class MimeType;
} }

View File

@@ -35,7 +35,7 @@
#include "texteditor_global.h" #include "texteditor_global.h"
#include <QtCore/QVariant> #include <QtCore/QVariantMap>
QT_BEGIN_NAMESPACE QT_BEGIN_NAMESPACE
class QSettings; class QSettings;

View File

@@ -36,8 +36,6 @@
#include "texteditor_global.h" #include "texteditor_global.h"
#include <QtGui/QWidget> #include <QtGui/QWidget>
#include <QtCore/QMap>
namespace TextEditor { namespace TextEditor {
@@ -75,6 +73,5 @@ private:
TabPreferences *m_tabPreferences; TabPreferences *m_tabPreferences;
}; };
} // namespace TextEditor } // namespace TextEditor
#endif // TABPREFERENCESWIDGET_H #endif // TABPREFERENCESWIDGET_H

View File

@@ -34,7 +34,8 @@
#define TEXTEDITOR_TABSETTINGSWIDGET_H #define TEXTEDITOR_TABSETTINGSWIDGET_H
#include "texteditor_global.h" #include "texteditor_global.h"
#include <QWidget>
#include <QtGui/QWidget>
namespace TextEditor { namespace TextEditor {
@@ -74,6 +75,5 @@ private:
Ui::TabSettingsWidget *ui; Ui::TabSettingsWidget *ui;
}; };
} // namespace TextEditor } // namespace TextEditor
#endif // TEXTEDITOR_TABSETTINGSWIDGET_H #endif // TEXTEDITOR_TABSETTINGSWIDGET_H

View File

@@ -106,6 +106,10 @@ TextEditorActionHandler::TextEditorActionHandler(const char *context,
this, SLOT(updateCurrentEditor(Core::IEditor*))); this, SLOT(updateCurrentEditor(Core::IEditor*)));
} }
TextEditorActionHandler::~TextEditorActionHandler()
{
}
void TextEditorActionHandler::setupActions(BaseTextEditorWidget *editor) void TextEditorActionHandler::setupActions(BaseTextEditorWidget *editor)
{ {
initializeActions(); initializeActions();

View File

@@ -34,16 +34,22 @@
#define TEXTEDITORACTIONHANDLER_H #define TEXTEDITORACTIONHANDLER_H
#include "texteditor_global.h" #include "texteditor_global.h"
#include "basetexteditor.h"
#include "coreplugin/icontext.h" #include <coreplugin/icontext.h>
#include <QtCore/QList>
#include <QtCore/QObject> #include <QtCore/QObject>
#include <QtCore/QPointer> #include <QtCore/QPointer>
#include <QtCore/QList> #include <QtCore/QList>
QT_FORWARD_DECLARE_CLASS(QAction)
namespace Core {
class ICore;
class IEditor;
}
namespace TextEditor { namespace TextEditor {
class BaseTextEditorWidget;
// Redirects slots from global actions to the respective editor. // Redirects slots from global actions to the respective editor.
@@ -60,6 +66,8 @@ public:
}; };
explicit TextEditorActionHandler(const char *context, uint optionalActions = None); explicit TextEditorActionHandler(const char *context, uint optionalActions = None);
~TextEditorActionHandler();
void setupActions(BaseTextEditorWidget *editor); void setupActions(BaseTextEditorWidget *editor);
void initializeActions(); void initializeActions();