From 611d0016dd94332a24c232b9e3710ae283064a44 Mon Sep 17 00:00:00 2001 From: Daniel Teske Date: Fri, 11 Jul 2014 11:54:49 +0200 Subject: [PATCH] ProjectWindow: Remove dead code The ProjectWindow page gets all objects of type IProjectPanelFactory from the object pool. Since ITargetPanelFactory is not derived from IProjectPanelFactory, the removed qobject_cast can never work. Change-Id: I52186e33e1992dc3556fcb2900719e9a8158da39 Reviewed-by: Tobias Hunger --- src/plugins/projectexplorer/projectwindow.cpp | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/plugins/projectexplorer/projectwindow.cpp b/src/plugins/projectexplorer/projectwindow.cpp index b784e8a8ebc..7cf088cae35 100644 --- a/src/plugins/projectexplorer/projectwindow.cpp +++ b/src/plugins/projectexplorer/projectwindow.cpp @@ -385,7 +385,7 @@ void ProjectWindow::showProperties(int index, int subIndex) // Set up custom panels again: int pos = 0; - IPanelFactory *fac = 0; + IProjectPanelFactory *fac = 0; // remember previous sub index state of target settings page if (TargetSettingsPanelWidget *previousPanelWidget = qobject_cast(m_currentWidget)) { @@ -421,11 +421,7 @@ void ProjectWindow::showProperties(int index, int subIndex) if (fac) { removeCurrentWidget(); - PropertiesPanel *panel = 0; - if (ITargetPanelFactory *ipf = qobject_cast(fac)) - panel = ipf->createPanel(project->activeTarget()); - else if (IProjectPanelFactory *ipf = qobject_cast(fac)) - panel = ipf->createPanel(project); + PropertiesPanel *panel = fac->createPanel(project); Q_ASSERT(panel); PanelsWidget *panelsWidget = new PanelsWidget(m_centralWidget);