feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Encourage marking of raw command line parameters

Browse Source 
Change-Id: Id66ac07732c66ab8c1232fe1f58042de8a61abb0
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2019-06-05 15:35:15 +02:00
parent 27dee4dc5c
commit 611e1ea837
19 changed files with 65 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/coreplugin/externaltool.cpp
View File

@@ -663,11 +663,11 @@ void ExternalToolRunner::run()
this, &ExternalToolRunner::readStandardError);
if (!m_resolvedWorkingDirectory.isEmpty())
m_process->setWorkingDirectory(m_resolvedWorkingDirectory);
m_process->setCommand(CommandLine(m_resolvedExecutable, m_resolvedArguments));
const CommandLine cmd{m_resolvedExecutable, m_resolvedArguments, CommandLine::Raw};
m_process->setCommand(cmd);
m_process->setEnvironment(m_resolvedEnvironment);
MessageManager::write(tr("Starting external tool \"%1\" %2")
.arg(m_resolvedExecutable.toUserOutput(), m_resolvedArguments),
MessageManager::Silent);
MessageManager::write(tr("Starting external tool \"%1\"")
.arg(cmd.toUserOutput()), MessageManager::Silent);
m_process->start();
}