feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Encourage marking of raw command line parameters

Browse Source 
Change-Id: Id66ac07732c66ab8c1232fe1f58042de8a61abb0
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2019-06-05 15:35:15 +02:00
parent 27dee4dc5c
commit 611e1ea837
19 changed files with 65 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/remotelinux/linuxdeviceprocess.cpp
View File

@@ -79,28 +79,28 @@ QString LinuxDeviceProcess::fullCommandLine(const Runnable &runnable) const
for (const QString &filePath : rcFilesToSource()) {
cmd.addArgs({"test", "-f", filePath});
cmd.addArgs("&&");
cmd.addArgs("&&", CommandLine::Raw);
cmd.addArgs({".", filePath});
cmd.addArgs(";");
cmd.addArgs(";", CommandLine::Raw);
}
if (!runnable.workingDirectory.isEmpty()) {
cmd.addArgs({"cd", runnable.workingDirectory});
cmd.addArgs("&&");
cmd.addArgs("&&", CommandLine::Raw);
}
if (!runInTerminal())
cmd.addArgs("echo $$ && ");
cmd.addArgs("echo $$ && ", CommandLine::Raw);
const Environment &env = runnable.environment;
for (auto it = env.constBegin(); it != env.constEnd(); ++it)
cmd.addArgs(env.key(it) + "='" + env.value(it) + '\'');
cmd.addArgs(env.key(it) + "='" + env.value(it) + '\'', CommandLine::Raw);
if (!runInTerminal())
cmd.addArg("exec");
cmd.addArg(runnable.executable);
cmd.addArgs(runnable.commandLineArguments);
cmd.addArgs(runnable.commandLineArguments, CommandLine::Raw);
return cmd.arguments();
}