feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CppEditor: Fix some clazy level0 warnings

Browse Source 
Use leftRef() instead [-Wclazy-qstring-ref]
Use multi-arg instead [-Wclazy-qstring-arg]

Change-Id: I4aa67e0d518060cdec4f96cb7a03a9a499f28f27
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Nikolai Kosjar
2019-02-07 12:29:36 +01:00
parent 4b26a8c66e
commit 612393889a
3 changed files with 24 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/cppeditor/cppdocumentationcommenthelper.cpp
View File

@@ -173,7 +173,7 @@ bool handleDoxygenCppStyleContinuation(QTextCursor &cursor)
return false; return false;
QString newLine(QLatin1Char('\n')); QString newLine(QLatin1Char('\n'));
newLine.append(text.left(offset)); // indent correctly newLine.append(text.leftRef(offset)); // indent correctly
newLine.append(commentMarker); newLine.append(commentMarker);
newLine.append(QLatin1Char(' ')); newLine.append(QLatin1Char(' '));

44
src/plugins/cppeditor/cppquickfixes.cpp
View File

@@ -3101,13 +3101,13 @@ public:
const QString declarationGetterTypeAndNameString = oo.prettyType(getterType, m_getterName); const QString declarationGetterTypeAndNameString = oo.prettyType(getterType, m_getterName);
const QString declarationGetter = QString::fromLatin1("%1%2()%3;\n") const QString declarationGetter = QString::fromLatin1("%1%2()%3;\n")
.arg(isStatic ? QLatin1String("static ") : QString()) .arg(isStatic ? QLatin1String("static ") : QString(),
.arg(declarationGetterTypeAndNameString) declarationGetterTypeAndNameString,
.arg(isStatic ? QString() : QLatin1String(" const")); isStatic ? QString() : QLatin1String(" const"));
const QString declarationSetter = QString::fromLatin1("%1void %2(%3);\n") const QString declarationSetter = QString::fromLatin1("%1void %2(%3);\n")
.arg(isStatic ? QLatin1String("static ") : QString()) .arg(isStatic ? QLatin1String("static ") : QString(),
.arg(m_setterName) m_setterName,
.arg(paramString); paramString);
if (generateGetter()) if (generateGetter())
declaration += declarationGetter; declaration += declarationGetter;
@@ -3118,22 +3118,22 @@ public:
// Construct implementation strings // Construct implementation strings
const QString implementationGetterTypeAndNameString = oo.prettyType( const QString implementationGetterTypeAndNameString = oo.prettyType(
getterType, QString::fromLatin1("%1::%2").arg(classString, m_getterName)); getterType, QString::fromLatin1("%1::%2").arg(classString, m_getterName));
const QString implementationGetter = QString::fromLatin1( const QString implementationGetter = QString::fromLatin1("%1()%2\n"
"%1()%2\n" "{\n"
"{\n" "return %3;\n"
"return %3;\n" "}")
"}") .arg(implementationGetterTypeAndNameString,
.arg(implementationGetterTypeAndNameString) isStatic ? QString() : QLatin1String(" const"),
.arg(isStatic ? QString() : QLatin1String(" const")) m_variableString);
.arg(m_variableString); const QString implementationSetter = QString::fromLatin1("void %1::%2(%3)\n"
const QString implementationSetter = QString::fromLatin1( "{\n"
"void %1::%2(%3)\n" "%4 = %5;\n"
"{\n" "}")
"%4 = %5;\n" .arg(classString,
"}") m_setterName,
.arg(classString).arg(m_setterName) paramString,
.arg(paramString).arg(m_variableString) m_variableString,
.arg(paramName); paramName);
QString implementation; QString implementation;
if (generateGetter()) if (generateGetter())

3
src/plugins/cppeditor/resourcepreviewhoverhandler.cpp
View File

@@ -204,8 +204,7 @@ QString ResourcePreviewHoverHandler::makeTooltip() const
ret += QString("<img src=\"file:///%1\" /><br/>").arg(m_resPath); ret += QString("<img src=\"file:///%1\" /><br/>").arg(m_resPath);
ret += QString("<a href=\"file:///%1\">%2</a>") ret += QString("<a href=\"file:///%1\">%2</a>")
.arg(m_resPath) .arg(m_resPath, QDir::toNativeSeparators(m_resPath));
.arg(QDir::toNativeSeparators(m_resPath));
return ret; return ret;
} }