feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

VCS: Avoid repetitive calls to cleanupDescription in submit editor

Browse Source 
It is called twice on each change to the text, and called again on
commit.

Change-Id: I8bfa2b37247a270f8b92e0b8a4e581278acf4cea
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
This commit is contained in:
Orgad Shaneh
2014-09-15 20:41:39 +03:00
committed by Orgad Shaneh
parent 2a8fa5579a
commit 6158a4ca58
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/plugins/vcsbase/submiteditorwidget.cpp
View File

@@ -157,6 +157,7 @@ struct SubmitEditorWidgetPrivate
bool m_ignoreChange;
bool m_descriptionMandatory;
bool m_updateInProgress;
QString m_description;
QActionPushButton *m_submitButton;
};
@@ -323,12 +324,7 @@ static QString wrappedText(const QTextEdit *e)
QString SubmitEditorWidget::descriptionText() const
{
QString rc = trimMessageText(lineWrap() ? wrappedText(d->m_ui.description) :
d->m_ui.description->toPlainText());
// append field entries
foreach (const SubmitFieldWidget *fw, d->m_fieldWidgets)
rc += fw->fieldValues();
return cleanupDescription(rc);
return d->m_description;
}
void SubmitEditorWidget::setDescriptionText(const QString &text)
@@ -555,6 +551,12 @@ void SubmitEditorWidget::hideDescription()
void SubmitEditorWidget::descriptionTextChanged()
{
QString rc = trimMessageText(lineWrap() ? wrappedText(d->m_ui.description) :
d->m_ui.description->toPlainText());
// append field entries
foreach (const SubmitFieldWidget *fw, d->m_fieldWidgets)
rc += fw->fieldValues();
d->m_description = cleanupDescription(rc);
updateSubmitAction();
}
@@ -562,7 +564,7 @@ bool SubmitEditorWidget::canSubmit() const
{
if (d->m_updateInProgress)
return false;
if (isDescriptionMandatory() && cleanupDescription(descriptionText()).trimmed().isEmpty())
if (isDescriptionMandatory() && d->m_description.trimmed().isEmpty())
return false;
const unsigned checkedCount = checkedFilesCount();
return d->m_emptyFileListEnabled || checkedCount > 0;