feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fix warning: "Missing emit keyword on signal call"

Browse Source 
[-Wclazy-incorrect-emit]

Change-Id: I93bdc6e23cdaccf35c9899ae16870ccc65a54f80
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This commit is contained in:
Alessandro Portale
2019-01-16 18:06:21 +01:00
parent 710e57a628
commit 616e19ff9e
42 changed files with 97 additions and 93 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/libs/utils/shellcommand.cpp
View File

@@ -336,7 +336,7 @@ SynchronousProcessResponse ShellCommand::runCommand(const FileName &binary,
QSharedPointer<OutputProxy> proxy(d->m_proxyFactory());
if (!(d->m_flags & SuppressCommandLogging))
proxy->appendCommand(dir, binary, arguments);
emit proxy->appendCommand(dir, binary, arguments);
if ((d->m_flags & FullySynchronously)
|| (!(d->m_flags & NoFullySync)
@@ -350,9 +350,9 @@ SynchronousProcessResponse ShellCommand::runCommand(const FileName &binary,
// Success/Fail message in appropriate window?
if (response.result == SynchronousProcessResponse::Finished) {
if (d->m_flags & ShowSuccessMessage)
proxy->appendMessage(response.exitMessage(binary.toUserOutput(), timeoutS));
emit proxy->appendMessage(response.exitMessage(binary.toUserOutput(), timeoutS));
} else if (!(d->m_flags & SuppressFailMessage)) {
proxy->appendError(response.exitMessage(binary.toUserOutput(), timeoutS));
emit proxy->appendError(response.exitMessage(binary.toUserOutput(), timeoutS));
}
}
@@ -385,14 +385,14 @@ SynchronousProcessResponse ShellCommand::runFullySynchronous(const FileName &bin
if (!d->m_aborted) {
const QString stdErr = resp.stdErr();
if (!stdErr.isEmpty() && !(d->m_flags & SuppressStdErr))
proxy->append(stdErr);
emit proxy->append(stdErr);
const QString stdOut = resp.stdOut();
if (!stdOut.isEmpty() && d->m_flags & ShowStdOut) {
if (d->m_flags & SilentOutput)
proxy->appendSilently(stdOut);
emit proxy->appendSilently(stdOut);
else
proxy->append(stdOut);
emit proxy->append(stdOut);
}
}
@@ -430,7 +430,7 @@ SynchronousProcessResponse ShellCommand::runSynchronous(const FileName &binary,
if (d->m_progressParser)
d->m_progressParser->parseProgress(text);
if (!(d->m_flags & SuppressStdErr))
proxy->appendError(text);
emit proxy->appendError(text);
if (d->m_progressiveOutput)
emit stdErrText(text);
});
@@ -445,7 +445,7 @@ SynchronousProcessResponse ShellCommand::runSynchronous(const FileName &binary,
if (d->m_progressParser)
d->m_progressParser->parseProgress(text);
if (d->m_flags & ShowStdOut)
proxy->append(text);
emit proxy->append(text);
if (d->m_progressiveOutput) {
emit stdOutText(text);
d->m_hadOutput = true;