feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fix warning: "Missing emit keyword on signal call"

Browse Source 
[-Wclazy-incorrect-emit]

Change-Id: I93bdc6e23cdaccf35c9899ae16870ccc65a54f80
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This commit is contained in:
Alessandro Portale
2019-01-16 18:06:21 +01:00
parent 710e57a628
commit 616e19ff9e
42 changed files with 97 additions and 93 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/libs/qmldebug/qmldebugconnection.cpp
View File

@@ -399,7 +399,7 @@ void QmlDebugConnection::newConnection()
connect(socket, &QLocalSocket::stateChanged,
this, [this](QLocalSocket::LocalSocketState state) {
logStateChange(socketStateToString(static_cast<QAbstractSocket::SocketState>(state)));
emit logStateChange(socketStateToString(static_cast<QAbstractSocket::SocketState>(state)));
});
socketConnected();

6
src/libs/qmleditorwidgets/contextpanewidget.cpp
View File

@@ -391,7 +391,7 @@ void ContextPaneWidget::onShowColorDialog(bool checked, const QPoint &p)
void ContextPaneWidget::onDisable(bool b)
{
enabledChanged(b);
emit enabledChanged(b);
if (!b) {
hide();
colorDialog()->hide();
@@ -491,7 +491,7 @@ void ContextPaneWidget::setPinButton()
m_toolButton->setFixedSize(20, 20);
m_toolButton->setToolTip(tr("Unpins the toolbar and moves it to the default position."));
pinnedChanged(true);
emit pinnedChanged(true);
if (m_resetAction) {
QSignalBlocker blocker(m_resetAction);
m_resetAction->setChecked(true);
@@ -508,7 +508,7 @@ void ContextPaneWidget::setLineButton()
m_toolButton->setToolTip(tr("Hides this toolbar. This toolbar can be"
" permanently disabled in the options page or in the context menu."));
pinnedChanged(false);
emit pinnedChanged(false);
if (m_resetAction) {
QSignalBlocker blocker(m_resetAction);
m_resetAction->setChecked(false);

8
src/libs/qmleditorwidgets/contextpanewidgetimage.cpp
View File

@@ -380,7 +380,7 @@ void ContextPaneWidgetImage::onPixmapDoubleClicked()
void ContextPaneWidgetImage::onLeftMarginsChanged()
{
if (previewDialog()->previewLabel()->leftMarging())
propertyChanged(QLatin1String("border.left"), previewDialog()->previewLabel()->leftMarging());
emit propertyChanged("border.left", previewDialog()->previewLabel()->leftMarging());
else
emit removeProperty(QLatin1String("border.left"));
}
@@ -388,7 +388,7 @@ void ContextPaneWidgetImage::onLeftMarginsChanged()
void ContextPaneWidgetImage::onRightMarginsChanged()
{
if (previewDialog()->previewLabel()->rightMarging())
propertyChanged(QLatin1String("border.right"), previewDialog()->previewLabel()->rightMarging());
emit propertyChanged("border.right", previewDialog()->previewLabel()->rightMarging());
else
emit removeProperty(QLatin1String("border.right"));
@@ -398,7 +398,7 @@ void ContextPaneWidgetImage::onRightMarginsChanged()
void ContextPaneWidgetImage::onTopMarginsChanged()
{
if (previewDialog()->previewLabel()->topMarging())
propertyChanged(QLatin1String("border.top"), previewDialog()->previewLabel()->topMarging());
emit propertyChanged("border.top", previewDialog()->previewLabel()->topMarging());
else
emit removeProperty(QLatin1String("border.top"));
}
@@ -406,7 +406,7 @@ void ContextPaneWidgetImage::onTopMarginsChanged()
void ContextPaneWidgetImage::onBottomMarginsChanged()
{
if (previewDialog()->previewLabel()->bottomMarging())
propertyChanged(QLatin1String("border.bottom"), previewDialog()->previewLabel()->bottomMarging());
emit propertyChanged("border.bottom", previewDialog()->previewLabel()->bottomMarging());
else
emit removeProperty(QLatin1String("border.bottom"));

16
src/libs/utils/shellcommand.cpp
View File

@@ -336,7 +336,7 @@ SynchronousProcessResponse ShellCommand::runCommand(const FileName &binary,
QSharedPointer<OutputProxy> proxy(d->m_proxyFactory());
if (!(d->m_flags & SuppressCommandLogging))
proxy->appendCommand(dir, binary, arguments);
emit proxy->appendCommand(dir, binary, arguments);
if ((d->m_flags & FullySynchronously)
|| (!(d->m_flags & NoFullySync)
@@ -350,9 +350,9 @@ SynchronousProcessResponse ShellCommand::runCommand(const FileName &binary,
// Success/Fail message in appropriate window?
if (response.result == SynchronousProcessResponse::Finished) {
if (d->m_flags & ShowSuccessMessage)
proxy->appendMessage(response.exitMessage(binary.toUserOutput(), timeoutS));
emit proxy->appendMessage(response.exitMessage(binary.toUserOutput(), timeoutS));
} else if (!(d->m_flags & SuppressFailMessage)) {
proxy->appendError(response.exitMessage(binary.toUserOutput(), timeoutS));
emit proxy->appendError(response.exitMessage(binary.toUserOutput(), timeoutS));
}
}
@@ -385,14 +385,14 @@ SynchronousProcessResponse ShellCommand::runFullySynchronous(const FileName &bin
if (!d->m_aborted) {
const QString stdErr = resp.stdErr();
if (!stdErr.isEmpty() && !(d->m_flags & SuppressStdErr))
proxy->append(stdErr);
emit proxy->append(stdErr);
const QString stdOut = resp.stdOut();
if (!stdOut.isEmpty() && d->m_flags & ShowStdOut) {
if (d->m_flags & SilentOutput)
proxy->appendSilently(stdOut);
emit proxy->appendSilently(stdOut);
else
proxy->append(stdOut);
emit proxy->append(stdOut);
}
}
@@ -430,7 +430,7 @@ SynchronousProcessResponse ShellCommand::runSynchronous(const FileName &binary,
if (d->m_progressParser)
d->m_progressParser->parseProgress(text);
if (!(d->m_flags & SuppressStdErr))
proxy->appendError(text);
emit proxy->appendError(text);
if (d->m_progressiveOutput)
emit stdErrText(text);
});
@@ -445,7 +445,7 @@ SynchronousProcessResponse ShellCommand::runSynchronous(const FileName &binary,
if (d->m_progressParser)
d->m_progressParser->parseProgress(text);
if (d->m_flags & ShowStdOut)
proxy->append(text);
emit proxy->append(text);
if (d->m_progressiveOutput) {
emit stdOutText(text);
d->m_hadOutput = true;

11
src/libs/utils/treemodel.cpp
View File

@@ -748,7 +748,8 @@ void TreeItem::update()
{
if (m_model) {
QModelIndex idx = index();
m_model->dataChanged(idx.sibling(idx.row(), 0), idx.sibling(idx.row(), m_model->m_columnCount - 1));
emit m_model->dataChanged(idx.sibling(idx.row(), 0),
idx.sibling(idx.row(), m_model->m_columnCount - 1));
}
}
@@ -756,7 +757,7 @@ void TreeItem::updateAll()
{
if (m_model) {
QModelIndex idx = index();
m_model->dataChanged(idx, idx.sibling(idx.row(), m_model->m_columnCount - 1));
emit m_model->dataChanged(idx, idx.sibling(idx.row(), m_model->m_columnCount - 1));
for (TreeItem *item : *this)
item->updateAll();
}
@@ -766,7 +767,7 @@ void TreeItem::updateColumn(int column)
{
if (m_model) {
QModelIndex idx = index();
m_model->dataChanged(idx.sibling(idx.row(), column), idx.sibling(idx.row(), column));
emit m_model->dataChanged(idx.sibling(idx.row(), column), idx.sibling(idx.row(), column));
}
}
@@ -893,13 +894,13 @@ void TreeItem::removeItemAt(int pos)
void TreeItem::expand()
{
QTC_ASSERT(m_model, return);
m_model->requestExpansion(index());
emit m_model->requestExpansion(index());
}
void TreeItem::collapse()
{
QTC_ASSERT(m_model, return);
m_model->requestCollapse(index());
emit m_model->requestCollapse(index());
}
void TreeItem::propagateModel(BaseTreeModel *m)

8
src/plugins/android/androidbuildapkstep.cpp
View File

@@ -289,8 +289,8 @@ void AndroidBuildApkStep::processFinished(int exitCode, QProcess::ExitStatus sta
bool AndroidBuildApkStep::verifyKeystorePassword()
{
if (!m_keystorePath.exists()) {
addOutput(tr("Cannot sign the package. Invalid keystore path (%1).")
.arg(m_keystorePath.toString()), OutputFormat::ErrorMessage);
emit addOutput(tr("Cannot sign the package. Invalid keystore path (%1).")
.arg(m_keystorePath.toString()), OutputFormat::ErrorMessage);
return false;
}
@@ -309,8 +309,8 @@ bool AndroidBuildApkStep::verifyCertificatePassword()
{
if (!AndroidManager::checkCertificateExists(m_keystorePath.toString(), m_keystorePasswd,
m_certificateAlias)) {
addOutput(tr("Cannot sign the package. Certificate alias %1 does not exist.")
.arg(m_certificateAlias), OutputFormat::ErrorMessage);
emit addOutput(tr("Cannot sign the package. Certificate alias %1 does not exist.")
.arg(m_certificateAlias), OutputFormat::ErrorMessage);
return false;
}

6
src/plugins/android/androidsdkmanager.cpp
View File

@@ -793,14 +793,14 @@ const AndroidSdkPackageList &AndroidSdkManagerPrivate::allPackages(bool forceUpd
void AndroidSdkManagerPrivate::reloadSdkPackages()
{
m_sdkManager.packageReloadBegin();
emit m_sdkManager.packageReloadBegin();
clearPackages();
lastSdkManagerPath = m_config.sdkManagerToolPath();
if (m_config.sdkToolsVersion().isNull()) {
// Configuration has invalid sdk path or corrupt installation.
m_sdkManager.packageReloadFinished();
emit m_sdkManager.packageReloadFinished();
return;
}
@@ -820,7 +820,7 @@ void AndroidSdkManagerPrivate::reloadSdkPackages()
parser.parsePackageListing(packageListing);
}
}
m_sdkManager.packageReloadFinished();
emit m_sdkManager.packageReloadFinished();
}
void AndroidSdkManagerPrivate::refreshSdkPackages(bool forceReload)

2
src/plugins/bookmarks/bookmarkmanager.cpp
View File

@@ -617,7 +617,7 @@ void BookmarkManager::updateActionStatus()
IEditor *editor = EditorManager::currentEditor();
const bool enableToggle = editor && !editor->document()->isTemporary();
updateActions(enableToggle, state());
emit updateActions(enableToggle, state());
}
void BookmarkManager::moveUp()

2
src/plugins/classview/classviewmanager.cpp
View File

@@ -354,7 +354,7 @@ void Manager::onProjectListChanged()
return;
// update to the latest state
requestTreeDataUpdate();
emit requestTreeDataUpdate();
}
/*!

4
src/plugins/coreplugin/dialogs/shortcutsettings.cpp
View File

@@ -425,7 +425,7 @@ void ShortcutSettingsWidget::importAction()
item->m_key = mapping.value(sid);
item->m_item->setText(2, item->m_key.toString(QKeySequence::NativeText));
if (item->m_item == commandList()->currentItem())
currentCommandChanged(item->m_item);
emit currentCommandChanged(item->m_item);
if (item->m_cmd->defaultKeySequence() != item->m_key)
setModified(item->m_item, true);
@@ -446,7 +446,7 @@ void ShortcutSettingsWidget::defaultAction()
item->m_item->setText(2, item->m_key.toString(QKeySequence::NativeText));
setModified(item->m_item, false);
if (item->m_item == commandList()->currentItem())
currentCommandChanged(item->m_item);
emit currentCommandChanged(item->m_item);
}
foreach (ShortcutItem *item, m_scitems)

8
src/plugins/coreplugin/find/searchresulttreemodel.cpp
View File

@@ -71,10 +71,10 @@ void SearchResultTreeModel::setShowReplaceUI(bool show)
void SearchResultTreeModel::setTextEditorFont(const QFont &font, const SearchResultColor &color)
{
layoutAboutToBeChanged();
emit layoutAboutToBeChanged();
m_textEditorFont = font;
m_color = color;
layoutChanged();
emit layoutChanged();
}
Qt::ItemFlags SearchResultTreeModel::flags(const QModelIndex &idx) const
@@ -355,7 +355,7 @@ void SearchResultTreeModel::addResultsToCurrentParent(const QList<SearchResultIt
existingItem->setGenerated(false);
existingItem->item = item;
QModelIndex itemIndex = index(insertionIndex, 0, m_currentIndex);
dataChanged(itemIndex, itemIndex);
emit dataChanged(itemIndex, itemIndex);
} else {
beginInsertRows(m_currentIndex, insertionIndex, insertionIndex);
m_currentParent->insertChild(insertionIndex, item);
@@ -363,7 +363,7 @@ void SearchResultTreeModel::addResultsToCurrentParent(const QList<SearchResultIt
}
}
}
dataChanged(m_currentIndex, m_currentIndex); // Make sure that the number after the file name gets updated
emit dataChanged(m_currentIndex, m_currentIndex); // Make sure that the number after the file name gets updated
}
static bool lessThanByPath(const SearchResultItem &a, const SearchResultItem &b)

2
src/plugins/debugger/debuggertooltipmanager.cpp
View File

@@ -895,7 +895,7 @@ void DebuggerToolTipHolder::releaseEngine()
setState(Released);
widget->model.m_enabled = false;
widget->model.layoutChanged();
emit widget->model.layoutChanged();
widget->titleLabel->setText(DebuggerToolTipManager::tr("%1 (Previous)").arg(context.expression));
}

2
src/plugins/debugger/watchhandler.cpp
View File

@@ -1856,7 +1856,7 @@ QMenu *WatchModel::createFormatMenu(WatchItem *item, QWidget *parent)
auto addBaseChangeAction = [this, menu](const QString &text, int base) {
addCheckableAction(menu, text, true, theUnprintableBase == base, [this, base] {
theUnprintableBase = base;
layoutChanged(); // FIXME
emit layoutChanged(); // FIXME
});
};

4
src/plugins/fakevim/fakevimplugin.cpp
View File

@@ -796,7 +796,7 @@ void FakeVimExCommandsWidget::defaultAction()
setModified(item, false);
item->setText(2, regex);
if (item == commandList()->currentItem())
currentCommandChanged(item);
emit currentCommandChanged(item);
}
}
}
@@ -1933,7 +1933,7 @@ void FakeVimPluginPrivate::handleExCommand(FakeVimHandler *handler, bool *handle
handler->showMessage(MessageInfo, Tr::tr("\"%1\" %2 %3L, %4C written")
.arg(fileName).arg(' ').arg(ba.count('\n')).arg(ba.size()));
if (cmd.cmd == "wq")
delayedQuitRequested(cmd.hasBang, m_editorToHandler.key(handler));
emit delayedQuitRequested(cmd.hasBang, m_editorToHandler.key(handler));
}
}
}

4
src/plugins/ios/iostoolhandler.cpp
View File

@@ -910,7 +910,7 @@ void IosSimulatorToolHandlerPrivate::stop(int errorCode)
}
toolExited(errorCode);
q->finished(q);
emit q->finished(q);
}
void IosSimulatorToolHandlerPrivate::installAppOnSimulator()
@@ -991,7 +991,7 @@ void IosSimulatorToolHandlerPrivate::launchAppOnSimulator(const QStringList &ext
.arg(response.commandOutput));
didStartApp(m_bundlePath, m_deviceId, Ios::IosToolHandler::Failure);
stop(-1);
q->finished(q);
emit q->finished(q);
}
};

2
src/plugins/languageclient/languageclientsettings.cpp
View File

@@ -201,7 +201,7 @@ void LanguageClientSettingsPageWidget::applyCurrentSettings()
m_currentSettings.setting->applyFromSettingsWidget(m_currentSettings.widget);
auto index = m_settings.indexForSetting(m_currentSettings.setting);
m_settings.dataChanged(index, index);
emit m_settings.dataChanged(index, index);
}
void LanguageClientSettingsPageWidget::addItem()

2
src/plugins/projectexplorer/appoutputpane.cpp
View File

@@ -736,7 +736,7 @@ void AppOutputPane::slotRunControlFinished2(RunControl *sender)
if (current && current == sender)
enableButtons(current);
ProjectExplorerPlugin::instance()->updateRunActions();
emit ProjectExplorerPlugin::instance()->updateRunActions();
#ifdef Q_OS_WIN
const bool isRunning = Utils::anyOf(m_runControlTabs, [](const RunControlTab &rt) {

2
src/plugins/projectexplorer/buildstep.cpp
View File

@@ -405,7 +405,7 @@ void BuildStepConfigWidget::setSummaryText(const QString &summaryText)
{
if (summaryText != m_summaryText) {
m_summaryText = summaryText;
updateSummary();
emit updateSummary();
}
}

4
src/plugins/projectexplorer/jsonwizard/jsonfieldpage.cpp
View File

@@ -693,7 +693,7 @@ void PathChooserField::setup(JsonFieldPage *page, const QString &name)
QTC_ASSERT(w, return);
page->registerFieldWithName(name, w, "path", SIGNAL(rawPathChanged(QString)));
QObject::connect(w, &PathChooser::rawPathChanged,
page, [page](QString) { page->completeChanged(); });
page, [page](QString) { emit page->completeChanged(); });
}
bool PathChooserField::validate(MacroExpander *expander, QString *message)
@@ -1061,7 +1061,7 @@ void IconListField::setup(JsonFieldPage *page, const QString &name)
return QString();
});
QObject::connect(selectionModel(), &QItemSelectionModel::selectionChanged, page, [page]() {
page->completeChanged();
emit page->completeChanged();
});
}

2
src/plugins/projectexplorer/kitmodel.cpp
View File

@@ -224,7 +224,7 @@ void KitModel::apply()
foreach (KitNode *n, m_toRemoveList)
n->widget->removeKit();
layoutChanged(); // Force update.
emit layoutChanged(); // Force update.
}
void KitModel::markForRemoval(Kit *k)

9
src/plugins/projectexplorer/osparser.cpp
View File

@@ -41,7 +41,8 @@ void OsParser::stdError(const QString &line)
if (Utils::HostOsInfo::isLinuxHost()) {
const QString trimmed = line.trimmed();
if (trimmed.contains(QLatin1String(": error while loading shared libraries:"))) {
addTask(Task(Task::Error, trimmed, Utils::FileName(), -1, Constants::TASK_CATEGORY_COMPILE));
emit addTask(Task(Task::Error, trimmed, Utils::FileName(), -1,
Constants::TASK_CATEGORY_COMPILE));
}
}
IOutputParser::stdError(line);
@@ -52,9 +53,9 @@ void OsParser::stdOutput(const QString &line)
if (Utils::HostOsInfo::isWindowsHost()) {
const QString trimmed = line.trimmed();
if (trimmed == QLatin1String("The process cannot access the file because it is being used by another process.")) {
addTask(Task(Task::Error, tr("The process cannot access the file because it is being used by another process.\n"
"Please close all running instances of your application before starting a build."),
Utils::FileName(), -1, Constants::TASK_CATEGORY_COMPILE));
emit addTask(Task(Task::Error, tr("The process cannot access the file because it is being used by another process.\n"
"Please close all running instances of your application before starting a build."),
Utils::FileName(), -1, Constants::TASK_CATEGORY_COMPILE));
m_hasFatalError = true;
}
}

6
src/plugins/projectexplorer/projectexplorer.cpp
View File

@@ -2120,7 +2120,7 @@ void ProjectExplorerPluginPrivate::restoreSession()
// delay opening projects from the command line even more
QTimer::singleShot(0, m_instance, []() {
ICore::openFiles(dd->m_arguments, ICore::OpenFilesFlags(ICore::CanContainLineAndColumnNumbers | ICore::SwitchMode));
m_instance->finishedInitialization();
emit m_instance->finishedInitialization();
});
updateActions();
}
@@ -2197,13 +2197,13 @@ void ProjectExplorerPluginPrivate::checkForShutdown()
--m_activeRunControlCount;
QTC_ASSERT(m_activeRunControlCount >= 0, m_activeRunControlCount = 0);
if (m_shuttingDown && m_activeRunControlCount == 0)
m_instance->asynchronousShutdownFinished();
emit m_instance->asynchronousShutdownFinished();
}
void ProjectExplorerPluginPrivate::timerEvent(QTimerEvent *ev)
{
if (m_shutdownWatchDogId == ev->timerId())
m_instance->asynchronousShutdownFinished();
emit m_instance->asynchronousShutdownFinished();
}
void ProjectExplorerPlugin::initiateInlineRenaming()

2
src/plugins/projectexplorer/projectmodels.cpp
View File

@@ -86,7 +86,7 @@ FlatModel::FlatModel(QObject *parent)
connect(sm, &SessionManager::aboutToLoadSession, this, &FlatModel::loadExpandData);
connect(sm, &SessionManager::aboutToSaveSession, this, &FlatModel::saveExpandData);
connect(sm, &SessionManager::projectAdded, this, &FlatModel::handleProjectAdded);
connect(sm, &SessionManager::startupProjectChanged, this, [this] { layoutChanged(); });
connect(sm, &SessionManager::startupProjectChanged, this, [this] { emit layoutChanged(); });
for (Project *project : SessionManager::projects())
handleProjectAdded(project);

4
src/plugins/projectexplorer/projectwelcomepage.cpp
View File

@@ -385,7 +385,7 @@ public:
m_expandedSessions.removeOne(sessionName);
else
m_expandedSessions.append(sessionName);
model->layoutChanged({QPersistentModelIndex(idx)});
emit model->layoutChanged({QPersistentModelIndex(idx)});
return true;
}
if (button == Qt::LeftButton) {
@@ -404,7 +404,7 @@ public:
}
}
if (ev->type() == QEvent::MouseMove) {
model->layoutChanged({QPersistentModelIndex(idx)}); // Somewhat brutish.
emit model->layoutChanged({QPersistentModelIndex(idx)}); // Somewhat brutish.
//update(option.rect);
return true;
}

2
src/plugins/projectexplorer/session.cpp
View File

@@ -381,7 +381,7 @@ void SessionManager::addProject(Project *pro)
d->m_projects.append(pro);
connect(pro, &Project::displayNameChanged,
m_instance, [pro]() { m_instance->projectDisplayNameChanged(pro); });
m_instance, [pro]() { emit m_instance->projectDisplayNameChanged(pro); });
emit m_instance->projectAdded(pro);
const auto updateFolderNavigation = [pro] {

2
src/plugins/qmakeprojectmanager/qmakestep.cpp
View File

@@ -242,7 +242,7 @@ bool QMakeStep::init(QList<const BuildStep *> &earlierSteps)
if (!tasks.isEmpty()) {
bool canContinue = true;
foreach (const ProjectExplorer::Task &t, tasks) {
addTask(t);
emit addTask(t);
if (t.type == Task::Error)
canContinue = false;
}

2
src/plugins/qmldesigner/components/itemlibrary/itemlibrarymodel.cpp
View File

@@ -126,7 +126,7 @@ void ItemLibraryModel::setSearchText(const QString &searchText)
bool changed = false;
updateVisibility(&changed);
if (changed)
dataChanged(QModelIndex(), QModelIndex());
emit dataChanged(QModelIndex(), QModelIndex());
}
}

14
src/plugins/qmldesigner/components/navigator/navigatortreemodel.cpp
View File

@@ -602,7 +602,7 @@ void NavigatorTreeModel::notifyDataChanged(const ModelNode &modelNode)
const QModelIndex index = indexForModelNode(modelNode);
const QAbstractItemModel *model = index.model();
const QModelIndex sibling = model ? model->sibling(index.row(), 2, index) : QModelIndex();
dataChanged(index, sibling);
emit dataChanged(index, sibling);
}
static QList<ModelNode> collectParents(const QList<ModelNode> &modelNodes)
@@ -628,22 +628,22 @@ QList<QPersistentModelIndex> NavigatorTreeModel::nodesToPersistentIndex(const QL
void NavigatorTreeModel::notifyModelNodesRemoved(const QList<ModelNode> &modelNodes)
{
QList<QPersistentModelIndex> indexes = nodesToPersistentIndex(collectParents(modelNodes));
layoutAboutToBeChanged(indexes);
layoutChanged(indexes);
emit layoutAboutToBeChanged(indexes);
emit layoutChanged(indexes);
}
void NavigatorTreeModel::notifyModelNodesInserted(const QList<ModelNode> &modelNodes)
{
QList<QPersistentModelIndex> indexes = nodesToPersistentIndex(collectParents(modelNodes));
layoutAboutToBeChanged(indexes);
layoutChanged(indexes);
emit layoutAboutToBeChanged(indexes);
emit layoutChanged(indexes);
}
void NavigatorTreeModel::notifyModelNodesMoved(const QList<ModelNode> &modelNodes)
{
QList<QPersistentModelIndex> indexes = nodesToPersistentIndex(collectParents(modelNodes));
layoutAboutToBeChanged(indexes);
layoutChanged(indexes);
emit layoutAboutToBeChanged(indexes);
emit layoutChanged(indexes);
}
void NavigatorTreeModel::setFilter(bool showOnlyVisibleItems)

2
src/plugins/qmldesigner/components/propertyeditor/qmlmodelnodeproxy.cpp
View File

@@ -53,7 +53,7 @@ void QmlModelNodeProxy::emitSelectionToBeChanged()
void QmlModelNodeProxy::emitSelectionChanged()
{
selectionChanged();
emit selectionChanged();
}
QmlItemNode QmlModelNodeProxy::qmlItemNode() const

2
src/plugins/qmldesigner/qmldesignerextension/connectioneditor/connectionview.cpp
View File

@@ -149,7 +149,7 @@ void ConnectionView::selectedNodesChanged(const QList<ModelNode> & selectedNodeL
if (connectionViewWidget()->currentTab() == ConnectionViewWidget::BindingTab
|| connectionViewWidget()->currentTab() == ConnectionViewWidget::DynamicPropertiesTab)
connectionViewWidget()->setEnabledAddButton(selectedNodeList.count() == 1);
emit connectionViewWidget()->setEnabledAddButton(selectedNodeList.count() == 1);
}
void ConnectionView::importsChanged(const QList<Import> & /*addedImports*/, const QList<Import> & /*removedImports*/)

12
src/plugins/qmldesigner/qmldesignerextension/connectioneditor/connectionviewwidget.cpp
View File

@@ -193,20 +193,20 @@ void ConnectionViewWidget::invalidateButtonStatus()
{
if (currentTab() == ConnectionTab) {
emit setEnabledRemoveButton(ui->connectionView->selectionModel()->hasSelection());
setEnabledAddButton(true);
emit setEnabledAddButton(true);
} else if (currentTab() == BindingTab) {
emit setEnabledRemoveButton(ui->bindingView->selectionModel()->hasSelection());
auto bindingModel = qobject_cast<BindingModel*>(ui->bindingView->model());
setEnabledAddButton(bindingModel->connectionView()->model() &&
bindingModel->connectionView()->selectedModelNodes().count() == 1);
emit setEnabledAddButton(bindingModel->connectionView()->model() &&
bindingModel->connectionView()->selectedModelNodes().count() == 1);
} else if (currentTab() == DynamicPropertiesTab) {
emit setEnabledRemoveButton(ui->dynamicPropertiesView->selectionModel()->hasSelection());
auto dynamicPropertiesModel = qobject_cast<DynamicPropertiesModel*>(ui->dynamicPropertiesView->model());
setEnabledAddButton(dynamicPropertiesModel->connectionView()->model() &&
dynamicPropertiesModel->connectionView()->selectedModelNodes().count() == 1);
emit setEnabledAddButton(dynamicPropertiesModel->connectionView()->model() &&
dynamicPropertiesModel->connectionView()->selectedModelNodes().count() == 1);
} else if (currentTab() == BackendTab) {
setEnabledAddButton(true);
emit setEnabledAddButton(true);
emit setEnabledRemoveButton(ui->backendView->selectionModel()->hasSelection());
}
}

2
src/plugins/qmldesigner/qmldesignerplugin.cpp
View File

@@ -474,7 +474,7 @@ void QmlDesignerPlugin::switchToTextModeDeferred()
void QmlDesignerPlugin::emitCurrentTextEditorChanged(Core::IEditor *editor)
{
d->blockEditorChange = true;
Core::EditorManager::instance()->currentEditorChanged(editor);
emit Core::EditorManager::instance()->currentEditorChanged(editor);
d->blockEditorChange = false;
}

2
src/plugins/qmlprofiler/qmlprofilertextmark.cpp
View File

@@ -65,7 +65,7 @@ void QmlProfilerTextMark::clicked()
{
int typeId = m_typeIds.takeFirst();
m_typeIds.append(typeId);
m_viewManager->typeSelected(typeId);
emit m_viewManager->typeSelected(typeId);
}
QmlProfilerTextMarkModel::QmlProfilerTextMarkModel(QObject *parent) : QObject(parent)

8
src/plugins/qtsupport/gettingstartedwelcomepage.cpp
View File

@@ -307,9 +307,11 @@ public:
m_sourceModel = newModel;
if (newModel) {
connect(newModel, &QAbstractItemModel::layoutAboutToBeChanged, this, [this] {
layoutAboutToBeChanged();
emit layoutAboutToBeChanged();
});
connect(newModel, &QAbstractItemModel::layoutChanged, this, [this] {
emit layoutChanged();
});
connect(newModel, &QAbstractItemModel::layoutChanged, this, [this] { layoutChanged(); });
connect(newModel, &QAbstractItemModel::modelAboutToBeReset, this, [this] {
beginResetModel();
});
@@ -360,7 +362,7 @@ public:
return;
QTC_ASSERT(columnCount >= 1, columnCount = 1);
m_columnCount = columnCount;
layoutChanged();
emit layoutChanged();
}
int rowCount(const QModelIndex &parent) const final

2
src/plugins/resourceeditor/qrceditor/resourceview.cpp
View File

@@ -176,7 +176,7 @@ void ResourceView::removeFiles(int prefixIndex, int firstFileIndex, int lastFile
void ResourceView::keyPressEvent(QKeyEvent *e)
{
if (e->key() == Qt::Key_Delete)
removeItem();
emit removeItem();
else
Utils::TreeView::keyPressEvent(e);
}

2
src/plugins/scxmleditor/plugin_interface/graphicsscene.cpp
View File

@@ -902,7 +902,7 @@ void GraphicsScene::addChild(BaseItem *item)
if (!m_baseItems.contains(item)) {
connect(item, &BaseItem::selectedStateChanged, this, &GraphicsScene::selectionChanged);
connect(item, &BaseItem::openToDifferentView, this, [=](BaseItem *item){
openStateView(item);
emit openStateView(item);
}, Qt::QueuedConnection);
m_baseItems << item;
}

4
src/plugins/texteditor/texteditor.cpp
View File

@@ -8038,10 +8038,10 @@ RefactorMarkers TextEditorWidget::refactorMarkers() const
void TextEditorWidget::setRefactorMarkers(const RefactorMarkers &markers)
{
foreach (const RefactorMarker &marker, d->m_refactorOverlay->markers())
requestBlockUpdate(marker.cursor.block());
emit requestBlockUpdate(marker.cursor.block());
d->m_refactorOverlay->setMarkers(markers);
foreach (const RefactorMarker &marker, markers)
requestBlockUpdate(marker.cursor.block());
emit requestBlockUpdate(marker.cursor.block());
}
TextBlockSelection::TextBlockSelection(const TextBlockSelection &other)

4
src/plugins/todo/todooutputpane.cpp
View File

@@ -165,7 +165,7 @@ void TodoOutputPane::scopeButtonClicked(QAbstractButton *button)
emit scanningScopeChanged(ScanningScopeSubProject);
else if (button == m_wholeProjectButton)
emit scanningScopeChanged(ScanningScopeProject);
setBadgeNumber(m_todoTreeView->model()->rowCount());
emit setBadgeNumber(m_todoTreeView->model()->rowCount());
}
void TodoOutputPane::todoTreeViewClicked(const QModelIndex &index)
@@ -187,7 +187,7 @@ void TodoOutputPane::todoTreeViewClicked(const QModelIndex &index)
void TodoOutputPane::updateTodoCount()
{
setBadgeNumber(m_todoTreeView->model()->rowCount());
emit setBadgeNumber(m_todoTreeView->model()->rowCount());
}
void TodoOutputPane::updateFilter()

2
src/plugins/valgrind/callgrind/callgrindparser.cpp
View File

@@ -264,7 +264,7 @@ void Parser::Private::parse(QIODevice *device)
foreach (Function *func, pendingFunctions)
func->finalize();
q->parserDataReady(); // emit
emit q->parserDataReady();
}
inline QString getValue(const QByteArray &line, const int prefixLength)

2
src/plugins/valgrind/callgrindtool.cpp
View File

@@ -897,7 +897,7 @@ void CallgrindTool::slotRequestDump()
{
//setBusy(true);
m_visualization->setText(tr("Populating..."));
dumpRequested();
emit dumpRequested();
}
void CallgrindTool::loadExternalLogFile()

4
src/plugins/valgrind/callgrindvisualisation.cpp
View File

@@ -250,11 +250,11 @@ void Visualization::Private::handleMousePressEvent(QMouseEvent *event,
const Function *func = q->functionForItem(itemAtPos);
if (doubleClicked) {
q->functionActivated(func);
emit q->functionActivated(func);
} else {
q->scene()->clearSelection();
itemAtPos->setSelected(true);
q->functionSelected(func);
emit q->functionSelected(func);
}
}

4
src/plugins/valgrind/valgrindrunner.cpp
View File

@@ -125,13 +125,13 @@ void ValgrindRunner::Private::run()
void ValgrindRunner::Private::handleRemoteStderr(const QString &b)
{
if (!b.isEmpty())
q->processOutputReceived(b, Utils::StdErrFormat);
emit q->processOutputReceived(b, Utils::StdErrFormat);
}
void ValgrindRunner::Private::handleRemoteStdout(const QString &b)
{
if (!b.isEmpty())
q->processOutputReceived(b, Utils::StdOutFormat);
emit q->processOutputReceived(b, Utils::StdOutFormat);
}
void ValgrindRunner::Private::localProcessStarted()