feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Analyzer: Use a StandardRunnable instead of an AnalyzerRunnable

Browse Source 
... with a lot potential to code consolidation.

Change-Id: I4d3a7fcc1cc6ae8763799f18cf9701695f387791
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
This commit is contained in:
hjk
2016-01-27 13:27:06 +01:00
parent fa17e27b7f
commit 61709e9266
13 changed files with 39 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/plugins/valgrind/valgrindplugin.cpp
View File

@@ -193,12 +193,13 @@ void ValgrindPlugin::extensionsInitialized()
return;
ValgrindRunControl *rc = mcTool->createRunControl(runConfig, MEMCHECK_RUN_MODE);
QTC_ASSERT(rc, return);
rc->setRunnable(dlg.runnable());
const auto runnable = dlg.runnable();
rc->setRunnable(runnable);
AnalyzerConnection connection;
connection.connParams = dlg.sshParams();
rc->setConnection(connection);
rc->setDisplayName(dlg.runnable().debuggee);
rc->setWorkingDirectory(dlg.workingDirectory());
rc->setDisplayName(runnable.executable);
rc->setWorkingDirectory(runnable.workingDirectory);
rc->setCustomStart();
ProjectExplorerPlugin::startRunControl(rc, MEMCHECK_RUN_MODE);
});
@@ -217,12 +218,13 @@ void ValgrindPlugin::extensionsInitialized()
return;
ValgrindRunControl *rc = cgTool->createRunControl(runConfig);
QTC_ASSERT(rc, return);
rc->setRunnable(dlg.runnable());
const auto runnable = dlg.runnable();
rc->setRunnable(runnable);
AnalyzerConnection connection;
connection.connParams = dlg.sshParams();
rc->setConnection(connection);
rc->setDisplayName(dlg.runnable().debuggee);
rc->setWorkingDirectory(dlg.workingDirectory());
rc->setDisplayName(runnable.executable);
rc->setWorkingDirectory(runnable.workingDirectory);
rc->setCustomStart();
ProjectExplorerPlugin::startRunControl(rc, CALLGRIND_RUN_MODE);
});