feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Avoid one use of SynchronousProcess for ps output

Browse Source 
Change-Id: I9b78810899f6d2c608092295ceef570bc136816d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2021-04-30 16:51:37 +02:00
parent 779e572ea3
commit 6182f39b06
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/projectexplorer/devicesupport/localprocesslist.cpp
View File

@@ -25,7 +25,7 @@
#include "localprocesslist.h" #include "localprocesslist.h"
#include <utils/synchronousprocess.h> #include <utils/qtcprocess.h>
#include <QLibrary> #include <QLibrary>
#include <QTimer> #include <QTimer>
@@ -156,12 +156,12 @@ static QList<DeviceProcessItem> getLocalProcessesUsingProc(const QDir &procDir)
static QMap<qint64, QString> getLocalProcessDataUsingPs(const QString &column) static QMap<qint64, QString> getLocalProcessDataUsingPs(const QString &column)
{ {
QMap<qint64, QString> result; QMap<qint64, QString> result;
QProcess psProcess; Utils::QtcProcess psProcess;
const QStringList args{"-e", "-o", "pid," + column}; psProcess.setCommand({"ps", {"-e", "-o", "pid," + column}});
psProcess.start("ps", args); psProcess.start();
if (psProcess.waitForStarted()) { if (psProcess.waitForStarted()) {
QByteArray output; QByteArray output;
if (Utils::SynchronousProcess::readDataFromProcess(psProcess, 30000, &output, nullptr, false)) { if (psProcess.readDataFromProcess(30000, &output, nullptr, false)) {
// Split "457 /Users/foo.app arg1 arg2" // Split "457 /Users/foo.app arg1 arg2"
const QStringList lines = QString::fromLocal8Bit(output).split(QLatin1Char('\n')); const QStringList lines = QString::fromLocal8Bit(output).split(QLatin1Char('\n'));
const int lineCount = lines.size(); const int lineCount = lines.size();